Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 212563005: Revert of Revert of Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
pdr., dglazkov, eae
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Revert of Revert of Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits (https://codereview.chromium.org/212763002/) Reason for revert: I don't think this was a reason of failures Original issue's description: > Revert of Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits (https://codereview.chromium.org/210573002/) > > Reason for revert: > This might have caused android tests failure: > http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/18266 > Speculatively reverting it. > > Original issue's description: > > Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits > > > > Remove the unused m_emSizeInFontUnits field and emSizeInFontUnits > > method from FontPlatformDataHarfBuzz. > > > > BUG=355806 > > R=pdr@chromium.org > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169955 > > TBR=pdr@chromium.org,dglazkov@chromium.org,eae@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=355806 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170048 TBR=pdr@chromium.org,dglazkov@chromium.org,eae@chromium.org NOTREECHECKS=true NOTRY=true BUG=355806 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp View 8 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsevik
Created Revert of Revert of Remove unused FontPlatformDataHarfBuzz::emSizeInFontUnits
6 years, 9 months ago (2014-03-26 12:22:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/212563005/1
6 years, 9 months ago (2014-03-26 12:22:34 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 12:22:50 UTC) #3
Message was sent while issue was closed.
Change committed as 170051

Powered by Google App Engine
This is Rietveld 408576698