Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 2125613002: [turbofan] Run value numbering as part of typed lowering. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Run value numbering as part of typed lowering. We can already benefit from value numbering (pure) nodes at this point in the graph, because it makes some later passes more efficient and reduces the graph size early. R=jarin@chromium.org Committed: https://crrev.com/b18b3877957cd218dda61c4e2cca635a0a6f5884 Cr-Commit-Position: refs/heads/master@{#37523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/compiler/pipeline.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-05 10:39:06 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125613002/1
4 years, 5 months ago (2016-07-05 10:39:13 UTC) #3
Jarin
lgtm
4 years, 5 months ago (2016-07-05 10:39:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125613002/1
4 years, 5 months ago (2016-07-05 10:40:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 11:02:10 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 11:02:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b18b3877957cd218dda61c4e2cca635a0a6f5884
Cr-Commit-Position: refs/heads/master@{#37523}

Powered by Google App Engine
This is Rietveld 408576698