Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 2125583002: [turbofan] Recognize fast path for Number.parseInt. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Recognize fast path for Number.parseInt. The Number.parseInt (and therefore the parseInt function on the global object) are often used instead of Math.floor or just plain int32 truncation, and we can easily recognize those cases and provide a fast path in TurboFan. R=jarin@chromium.org Committed: https://crrev.com/f50721d56d29ade284730739befc62b99cbf7645 Cr-Commit-Position: refs/heads/master@{#37518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/type-cache.h View 1 chunk +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-05 09:24:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125583002/1
4 years, 5 months ago (2016-07-05 09:24:59 UTC) #3
Benedikt Meurer
Hey Jaro, Here's some low hanging fool. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-05 09:25:44 UTC) #4
Jarin
lgtm
4 years, 5 months ago (2016-07-05 09:29:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125583002/1
4 years, 5 months ago (2016-07-05 09:29:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 09:50:01 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 09:52:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f50721d56d29ade284730739befc62b99cbf7645
Cr-Commit-Position: refs/heads/master@{#37518}

Powered by Google App Engine
This is Rietveld 408576698