Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2125533002: [Mac] Draw the caps lock indicator on the left side for RTL direction. (Closed)

Created:
4 years, 5 months ago by Sungmann Cho
Modified:
4 years, 5 months ago
Reviewers:
jbroman
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Draw the caps lock indicator on the left side for RTL direction. For RTL direction, the caps lock indicator for password fields should be drawn on the left side of it, but currently it is always drawn on the right side. This CL makes it possible to draw the caps lock indicator on the left or right side depend on current writing direction. BUG=623784 Committed: https://crrev.com/dec7875f088d45cd79a82a985c14dfdc7b2c1825 Cr-Commit-Position: refs/heads/master@{#404665}

Patch Set 1 #

Patch Set 2 : Add a layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/caps-lock-indicator-enabled-rtl.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.mm View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Sungmann Cho
Please take a look. Thanks!
4 years, 5 months ago (2016-07-05 05:45:09 UTC) #3
Sungmann Cho
jbroman: Could you please take a look? Thanks!
4 years, 5 months ago (2016-07-08 23:35:45 UTC) #5
jbroman
Looks good; could you please add a layout test? A fairly straightforward modification of fast/text/caps-lock-indicator-enabled.html ...
4 years, 5 months ago (2016-07-09 20:13:00 UTC) #6
Sungmann Cho
I added a layout test for this CL. As this was the first time to ...
4 years, 5 months ago (2016-07-10 10:26:13 UTC) #7
jbroman
lgtm
4 years, 5 months ago (2016-07-11 14:47:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125533002/20001
4 years, 5 months ago (2016-07-11 14:50:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 16:02:49 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 16:03:01 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 16:04:50 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dec7875f088d45cd79a82a985c14dfdc7b2c1825
Cr-Commit-Position: refs/heads/master@{#404665}

Powered by Google App Engine
This is Rietveld 408576698