Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 212553009: Harden internal uses of .chain (Closed)

Created:
6 years, 9 months ago by rossberg
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Harden internal uses of .chain R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/promise.js View 3 chunks +6 lines, -4 lines 0 comments Download
M test/mjsunit/es6/promises.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
6 years, 9 months ago (2014-03-27 12:47:55 UTC) #1
Yang
On 2014/03/27 12:47:55, rossberg wrote: LGTM. Though .catch now calls .then in the same way. ...
6 years, 9 months ago (2014-03-27 14:44:55 UTC) #2
rossberg
On 2014/03/27 14:44:55, Yang wrote: > On 2014/03/27 12:47:55, rossberg wrote: > > LGTM. Though ...
6 years, 9 months ago (2014-03-27 14:48:28 UTC) #3
rossberg
6 years, 9 months ago (2014-03-27 16:11:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20309 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698