Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 212553008: Add Bogus initialization for external_elements_kind and fixed_elements_kind (Closed)

Created:
6 years, 9 months ago by haitao.feng
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add Bogus initialization for external_elements_kind and fixed_elements_kind R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20315

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/runtime.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haitao.feng
gcc 4.7.3 complains " error: ‘external_elements_kind’ may be used uninitialized in this function [-Werror=maybe-uninitialized]" and ...
6 years, 9 months ago (2014-03-27 09:40:56 UTC) #1
Dmitry Lomov (no reviews)
lgtm with nit https://codereview.chromium.org/212553008/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/212553008/diff/1/src/runtime.cc#newcode1047 src/runtime.cc:1047: ElementsKind external_elements_kind = EXTERNAL_INT8_ELEMENTS; Add "// ...
6 years, 9 months ago (2014-03-27 11:18:48 UTC) #2
haitao.feng
https://codereview.chromium.org/212553008/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/212553008/diff/1/src/runtime.cc#newcode1047 src/runtime.cc:1047: ElementsKind external_elements_kind = EXTERNAL_INT8_ELEMENTS; On 2014/03/27 11:18:49, Dmitry Lomov ...
6 years, 9 months ago (2014-03-27 11:54:11 UTC) #3
Dmitry Lomov (no reviews)
On 2014/03/27 11:54:11, haitao.feng wrote: > https://codereview.chromium.org/212553008/diff/1/src/runtime.cc > File src/runtime.cc (right): > > https://codereview.chromium.org/212553008/diff/1/src/runtime.cc#newcode1047 > ...
6 years, 9 months ago (2014-03-27 17:40:34 UTC) #4
Dmitry Lomov (no reviews)
6 years, 9 months ago (2014-03-27 17:40:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20315 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698