Overview Tray Button should not be visible on login screen

ash/system/overview/overview_button_tray.h

Index: ash/system/overview/overview_button_tray.h
diff --git a/ash/system/overview/overview_button_tray.h b/ash/system/overview/overview_button_tray.h
index 0a16e4781f99bb90ae337634bc2561e9b498e91b..ea46a2f6cc1ba530715643a293a7667e8e39bebc 100644
--- a/ash/system/overview/overview_button_tray.h
+++ b/ash/system/overview/overview_button_tray.h
@@ -40,6 +40,10 @@ class ASH_EXPORT OverviewButtonTray : public internal::TrayBackgroundView,
       const views::TrayBubbleView* bubble_view) OVERRIDE;
   virtual void SetShelfAlignment(ShelfAlignment alignment) OVERRIDE;
 
+  // Updates the tray's visibility based on the LoginStatus and the current
+  // state of MaximizeMode
+  virtual void UpdateAfterLoginStatusChange(user::LoginStatus status);

[sadrul, 2014/03/28 21:23:35]

This doesn't need to be virtual?

Also, you should move this above the overrides.

[jonross, 2014/03/31 15:09:01]

Currently no. Each tray in the StatusAreaWidget just implemented this method
themselves. I can move it up to their common ancestor though.

[jonross, 2014/03/31 15:09:01]

Done.

+
  private:
   friend class OverviewButtonTrayTest;
 
@@ -47,6 +51,10 @@ class ASH_EXPORT OverviewButtonTray : public internal::TrayBackgroundView,
   // alignment of the shelf.
   void SetIconBorderForShelfAlignment();
 
+  // Sets the icon to visible if |maximize_mode_enabled| and
+  // WindowSelectorController::CanSelect.
+  void UpdateIconVisibility(bool maximize_mode_enabled);
+
   // Weak pointer, will be parented by TrayContainer for its lifetime.
   views::ImageView* icon_;