[repaint-after-layout] Skip invalidations if our RenderView did a full invalidation.

Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 1026 matching lines @@
     ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled());
     ASSERT(!root->needsLayout());
     // We should only repaint for the outer most layout. This works as
     // we continue to track repaint rects until this function is called.
     ASSERT(!m_nestedLayoutCount);
 
     // FIXME: really, we're in the repaint phase here, and the compositing queries are legal.
     // Until those states are fully fledged, I'll just disable the ASSERTS.
     DisableCompositingQueryAsserts disabler;
 
+    // If the RenderView did a full invalidation, skip issuing invalidations for
+    // the child RenderObjects as they will be covered by the RenderView invalidation.
+    if (root->isRenderView() && root->shouldDoFullRepaintAfterLayout()) {

[Julien - ping for review, 2014/03/31 20:00:56]

I think we could simplify even further here as we do the following:
- if m_doFullRepaint == true, mark RenderView as needing full repaint.
- check shouldDoFullRepaintAfterLayout() here.

It seems we could just remove the first part of the logic and just check
m_doFullRepaint here.

Also it seems like if we are doing a full repaint, we don't care what the root
for layout is. We would just have to be careful to repaint the RenderView.

[dsinclair, 2014/03/31 20:10:24]

Done.

+        root->repaintAfterLayoutIfNeeded(root->containerForRepaint(),
+            root->shouldDoFullRepaintAfterLayout(), root->oldRepaintRect(), &(root->newRepaintRect()));
+
+        // Clear the invalidation flags for the root and child renderers.
+        for (RenderObject* renderer = root; renderer; renderer = renderer->nextInPreOrder()) {
+            renderer->clearRepaintState();
+        }
+        return;
+    }
+
     for (RenderObject* renderer = root; renderer; renderer = renderer->nextInPreOrder()) {
-        const LayoutRect& oldRepaintRect = renderer->oldRepaintRect();
-        const LayoutRect& newRepaintRect = renderer->newRepaintRect();
-
-        if ((renderer->onlyNeededPositionedMovementLayout() && renderer->compositingState() != PaintsIntoOwnBacking)
-            || (renderer->shouldDoFullRepaintIfSelfPaintingLayer()
-                && renderer->hasLayer()
-                && toRenderLayerModelObject(renderer)->layer()->isSelfPaintingLayer())) {
-            renderer->setShouldDoFullRepaintAfterLayout(true);
-        }
+        renderer->updateShouldDoFullRepaintAfterLayout();

[Julien - ping for review, 2014/03/31 20:00:56]

I find that this function obfuscate the code as 'update' is a generic term. I
would just leave the code inlined (as I couldn't think of a better name for it).

[dsinclair, 2014/03/31 20:10:24]

Done.

 
         // FIXME: Currently renderers with layers will get repainted when we call updateLayerPositionsAfterLayout.
         // That call should be broken apart to position the layers be done before
         // the repaintTree call so this will repaint everything.
         bool didFullRepaint = false;
         if (!renderer->layoutDidGetCalled()) {
             if (renderer->shouldDoFullRepaintAfterLayout()) {
                 renderer->repaint();
                 didFullRepaint = true;
             }
 
         } else {
             didFullRepaint = renderer->repaintAfterLayoutIfNeeded(renderer->containerForRepaint(),
-                renderer->shouldDoFullRepaintAfterLayout(), oldRepaintRect, &newRepaintRect);
+                renderer->shouldDoFullRepaintAfterLayout(), renderer->oldRepaintRect(), &(renderer->newRepaintRect()));
         }
 
         if (!didFullRepaint)
             renderer->repaintOverflowIfNeeded();
 
         // Repaint any scrollbars if there is a scrollable area for this renderer.
         if (RenderLayerScrollableArea* area = renderer->enclosingLayer()->scrollableArea()) {
             if (area->hasVerticalBarDamage())
                 renderer->repaintRectangle(area->verticalBarDamage());
             if (area->hasHorizontalBarDamage())
@@ skipping 2172 matching lines @@
 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation orientation)
 {
     ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
     if (AXObjectCache* cache = axObjectCache()) {
         cache->remove(scrollbar);
         cache->handleScrollbarUpdate(this);
     }
 }
 
 } // namespace WebCore