[repaint-after-layout] Skip invalidations if our RenderView did a full invalidation.

Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 1026 matching lines @@
     ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled());
     ASSERT(!root->needsLayout());
     // We should only repaint for the outer most layout. This works as
     // we continue to track repaint rects until this function is called.
     ASSERT(!m_nestedLayoutCount);
 
     // FIXME: really, we're in the repaint phase here, and the compositing queries are legal.
     // Until those states are fully fledged, I'll just disable the ASSERTS.
     DisableCompositingQueryAsserts disabler;
 
+    root->updateShouldDoFullRepaintAfterLayout();

[Julien - ping for review, 2014/03/31 17:31:26]

Are you sure this code is needed? (Document won't be marked for layout itself
-except for the first layout which shouldn't generate any invalidation anyway -
as its style can't be changed programmatically)

[dsinclair, 2014/03/31 19:34:56]

Done.

+    bool renderViewDidFullInvalidation = root->isRenderView() && root->shouldDoFullRepaintAfterLayout();
+
     for (RenderObject* renderer = root; renderer; renderer = renderer->nextInPreOrder()) {
+        // If the RenderView did a full invalidation, and that's the view that we're part
+        // of, skip issuing invalidations for the RenderObject as it will be
+        // covered by the RenderView invalidation.
+        if (renderer != root && (renderer->view() == root) && renderViewDidFullInvalidation) {
+            renderer->clearRepaintState();
+            continue;
+        }

[Julien - ping for review, 2014/03/31 17:31:26]

I would just pull this code out of the previous loop as:
- you can think of this as a fast path.
- you can simplify the code a lot if you do:

for (RenderObject* renderer = root->firstChild(); renderer;
renderer->nextInPreOrder(root->firstChild())
    renderer->clearRepaintState();

[dsinclair, 2014/03/31 19:34:56]

Done.

+
         const LayoutRect& oldRepaintRect = renderer->oldRepaintRect();
         const LayoutRect& newRepaintRect = renderer->newRepaintRect();
 
-        if ((renderer->onlyNeededPositionedMovementLayout() && renderer->compositingState() != PaintsIntoOwnBacking)
-            || (renderer->shouldDoFullRepaintIfSelfPaintingLayer()
-                && renderer->hasLayer()
-                && toRenderLayerModelObject(renderer)->layer()->isSelfPaintingLayer())) {
-            renderer->setShouldDoFullRepaintAfterLayout(true);
-        }
+        renderer->updateShouldDoFullRepaintAfterLayout();
 
         // FIXME: Currently renderers with layers will get repainted when we call updateLayerPositionsAfterLayout.
         // That call should be broken apart to position the layers be done before
         // the repaintTree call so this will repaint everything.
         bool didFullRepaint = false;
         if (!renderer->layoutDidGetCalled()) {
             if (renderer->shouldDoFullRepaintAfterLayout()) {
                 renderer->repaint();
                 didFullRepaint = true;
             }
@@ skipping 2186 matching lines @@
 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation orientation)
 {
     ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
     if (AXObjectCache* cache = axObjectCache()) {
         cache->remove(scrollbar);
         cache->handleScrollbarUpdate(this);
     }
 }
 
 } // namespace WebCore