[repaint-after-layout] Skip invalidations if our RenderView did a full invalidation.

Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 1019 matching lines @@
     ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled());
     ASSERT(!root->needsLayout());
     // We should only repaint for the outer most layout. This works as
     // we continue to track repaint rects until this function is called.
     ASSERT(!m_nestedLayoutCount);
 
     // FIXME: really, we're in the repaint phase here, and the compositing queries are legal.
     // Until those states are fully fledged, I'll just disable the ASSERTS.
     DisableCompositingQueryAsserts disabler;
 
+    bool renderViewDidFullInvalidation = false;
+
     for (RenderObject* renderer = root; renderer; renderer = renderer->nextInPreOrder()) {
+        // If the RenderView did a full invalidation, and that's the view that we're part
+        // of, skip issuing invalidations for the RenderObject as it will be
+        // covered by the RenderView invalidation.
+        if (!renderer->hasLayer() && renderer != root && (renderer->view() == root) && renderViewDidFullInvalidation) {

[Julien - ping for review, 2014/03/27 22:37:26]

I don't think we should check hasLayer() here as it's conceptually wrong to
treat renderers with a layer differently (especially in the world where
repaint-after-layout has super-seeded RenderLayerRepainter).

[dsinclair, 2014/03/28 18:35:26]

Done.

+            renderer->clearRepaintState();
+            continue;
+        }
+
         const LayoutRect& oldRepaintRect = renderer->oldRepaintRect();
         const LayoutRect& newRepaintRect = renderer->newRepaintRect();
 
         if ((renderer->onlyNeededPositionedMovementLayout() && renderer->compositingState() != PaintsIntoOwnBacking)
             || (renderer->shouldDoFullRepaintIfSelfPaintingLayer()
                 && renderer->hasLayer()
                 && toRenderLayerModelObject(renderer)->layer()->isSelfPaintingLayer())) {
             renderer->setShouldDoFullRepaintAfterLayout(true);
         }
 
+        if (renderer == root && root->isRenderView())

[Julien - ping for review, 2014/03/27 22:37:26]

Note that this check will be run for each renderer when it's only needed for the
view. This obscures the intent pretty badly. I would rather have that checked
above with a fast path.

[dsinclair, 2014/03/28 18:35:26]

Done.

+            renderViewDidFullInvalidation = renderer->shouldDoFullRepaintAfterLayout();
+
         // FIXME: Currently renderers with layers will get repainted when we call updateLayerPositionsAfterLayout.
         // That call should be broken apart to position the layers be done before
         // the repaintTree call so this will repaint everything.
         bool didFullRepaint = false;
         if (!renderer->layoutDidGetCalled()) {
             if (renderer->shouldDoFullRepaintAfterLayout()) {
                 renderer->repaint();
                 didFullRepaint = true;
             }
 
@@ skipping 2186 matching lines @@
 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation orientation)
 {
     ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
     if (AXObjectCache* cache = axObjectCache()) {
         cache->remove(scrollbar);
         cache->handleScrollbarUpdate(this);
     }
 }
 
 } // namespace WebCore