Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: src/objects-visiting-inl.h

Issue 212553003: Reland r19897 "Fix memory leak caused by treating Code::next_code_link as strong in marker. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-visiting.h ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 881 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 RelocInfo::ModeMask(RelocInfo::JS_RETURN) | 892 RelocInfo::ModeMask(RelocInfo::JS_RETURN) |
893 RelocInfo::ModeMask(RelocInfo::DEBUG_BREAK_SLOT) | 893 RelocInfo::ModeMask(RelocInfo::DEBUG_BREAK_SLOT) |
894 RelocInfo::ModeMask(RelocInfo::RUNTIME_ENTRY); 894 RelocInfo::ModeMask(RelocInfo::RUNTIME_ENTRY);
895 895
896 // There are two places where we iterate code bodies: here and the 896 // There are two places where we iterate code bodies: here and the
897 // templated CodeIterateBody (below). They should be kept in sync. 897 // templated CodeIterateBody (below). They should be kept in sync.
898 IteratePointer(v, kRelocationInfoOffset); 898 IteratePointer(v, kRelocationInfoOffset);
899 IteratePointer(v, kHandlerTableOffset); 899 IteratePointer(v, kHandlerTableOffset);
900 IteratePointer(v, kDeoptimizationDataOffset); 900 IteratePointer(v, kDeoptimizationDataOffset);
901 IteratePointer(v, kTypeFeedbackInfoOffset); 901 IteratePointer(v, kTypeFeedbackInfoOffset);
902 IterateNextCodeLink(v, kNextCodeLinkOffset);
902 IteratePointer(v, kConstantPoolOffset); 903 IteratePointer(v, kConstantPoolOffset);
903 904
904 RelocIterator it(this, mode_mask); 905 RelocIterator it(this, mode_mask);
905 Isolate* isolate = this->GetIsolate(); 906 Isolate* isolate = this->GetIsolate();
906 for (; !it.done(); it.next()) { 907 for (; !it.done(); it.next()) {
907 it.rinfo()->Visit(isolate, v); 908 it.rinfo()->Visit(isolate, v);
908 } 909 }
909 } 910 }
910 911
911 912
(...skipping 14 matching lines...) Expand all
926 reinterpret_cast<Object**>(this->address() + kRelocationInfoOffset)); 927 reinterpret_cast<Object**>(this->address() + kRelocationInfoOffset));
927 StaticVisitor::VisitPointer( 928 StaticVisitor::VisitPointer(
928 heap, 929 heap,
929 reinterpret_cast<Object**>(this->address() + kHandlerTableOffset)); 930 reinterpret_cast<Object**>(this->address() + kHandlerTableOffset));
930 StaticVisitor::VisitPointer( 931 StaticVisitor::VisitPointer(
931 heap, 932 heap,
932 reinterpret_cast<Object**>(this->address() + kDeoptimizationDataOffset)); 933 reinterpret_cast<Object**>(this->address() + kDeoptimizationDataOffset));
933 StaticVisitor::VisitPointer( 934 StaticVisitor::VisitPointer(
934 heap, 935 heap,
935 reinterpret_cast<Object**>(this->address() + kTypeFeedbackInfoOffset)); 936 reinterpret_cast<Object**>(this->address() + kTypeFeedbackInfoOffset));
937 StaticVisitor::VisitNextCodeLink(
938 heap,
939 reinterpret_cast<Object**>(this->address() + kNextCodeLinkOffset));
936 StaticVisitor::VisitPointer( 940 StaticVisitor::VisitPointer(
937 heap, 941 heap,
938 reinterpret_cast<Object**>(this->address() + kConstantPoolOffset)); 942 reinterpret_cast<Object**>(this->address() + kConstantPoolOffset));
939 943
940 944
941 RelocIterator it(this, mode_mask); 945 RelocIterator it(this, mode_mask);
942 for (; !it.done(); it.next()) { 946 for (; !it.done(); it.next()) {
943 it.rinfo()->template Visit<StaticVisitor>(heap); 947 it.rinfo()->template Visit<StaticVisitor>(heap);
944 } 948 }
945 } 949 }
946 950
947 951
948 } } // namespace v8::internal 952 } } // namespace v8::internal
949 953
950 #endif // V8_OBJECTS_VISITING_INL_H_ 954 #endif // V8_OBJECTS_VISITING_INL_H_
OLDNEW
« no previous file with comments | « src/objects-visiting.h ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698