Issue 212553003: Reland r19897 "Fix memory leak caused by treating Code::next_code_link as strong in marker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212553003: Reland r19897 "Fix memory leak caused by treating Code::next_code_link as strong in marker. (Closed)

Created:
6 years, 9 months ago by ulan

Modified:
6 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland r19897 "Fix memory leak caused by treating Code::next_code_link as strong in marker. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20282

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -18 lines)			Patch
M	src/heap.cc	View	3 chunks	+18 lines, -1 line	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/objects.h	View	4 chunks	+7 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View	3 chunks	+6 lines, -14 lines	0 comments	Download
M	src/objects-visiting.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects-visiting-inl.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+96 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ulan

PTAL. The only difference is the addition of ClearWeakList in heap.cc as we discussed offline

6 years, 9 months ago (2014-03-26 10:24:13 UTC) #1

Michael Starzinger

LGTM to heap.cc, I didn't look at the rest this time around.

6 years, 9 months ago (2014-03-26 15:03:03 UTC) #2

ulan

6 years, 9 months ago (2014-03-26 15:15:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20282 (presubmit successful).