Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 212553002: Avoid deadlock when attempting to GC during synchronous loading in a worker. (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Avoid deadlock when attempting to GC during synchronous loading in a worker. R=haraken@chromium.org, tkent@chromium.org, vegorov@chromium.org BUG=356307 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Mads Ager (chromium)
6 years, 9 months ago (2014-03-26 09:42:05 UTC) #1
haraken
LGTM. I'm just curious but how did you notice the bug?
6 years, 9 months ago (2014-03-26 09:45:48 UTC) #2
Mads Ager (chromium)
Have a look at the bug report: crbug.com/356307 The process is killed from the side ...
6 years, 9 months ago (2014-03-26 09:48:26 UTC) #3
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-26 09:48:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/212553002/1
6 years, 9 months ago (2014-03-26 09:48:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 10:15:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-26 10:15:06 UTC) #7
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-26 10:36:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/212553002/1
6 years, 9 months ago (2014-03-26 10:36:25 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 10:40:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-26 10:40:17 UTC) #11
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-26 10:54:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/212553002/1
6 years, 9 months ago (2014-03-26 10:54:20 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 11:57:49 UTC) #14
Message was sent while issue was closed.
Change committed as 170047

Powered by Google App Engine
This is Rietveld 408576698