Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: components/test_runner/test_runner.cc

Issue 2125523003: Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 2c09561a1839db360232c7d819289024938affd2..246e0eab4998b4018cdf124ed6ca9c7e0c6ea95c 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -197,7 +197,7 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
void SetAllowRunningOfInsecureContent(bool allowed);
void SetAutoplayAllowed(bool allowed);
void SetAllowUniversalAccessFromFileURLs(bool allow);
- void SetAlwaysAcceptCookies(bool accept);
+ void SetBlockThirdPartyCookies(bool block);
void SetAudioData(const gin::ArrayBufferView& view);
void SetBackingScaleFactor(double value, v8::Local<v8::Function> callback);
void SetBluetoothFakeAdapter(const std::string& adapter_name,
@@ -492,8 +492,8 @@ gin::ObjectTemplateBuilder TestRunnerBindings::GetObjectTemplateBuilder(
.SetMethod("setAutoplayAllowed", &TestRunnerBindings::SetAutoplayAllowed)
.SetMethod("setAllowUniversalAccessFromFileURLs",
&TestRunnerBindings::SetAllowUniversalAccessFromFileURLs)
- .SetMethod("setAlwaysAcceptCookies",
- &TestRunnerBindings::SetAlwaysAcceptCookies)
+ .SetMethod("setBlockThirdPartyCookies",
+ &TestRunnerBindings::SetBlockThirdPartyCookies)
.SetMethod("setAudioData", &TestRunnerBindings::SetAudioData)
.SetMethod("setBackingScaleFactor",
&TestRunnerBindings::SetBackingScaleFactor)
@@ -1264,9 +1264,9 @@ void TestRunnerBindings::SetDatabaseQuota(int quota) {
runner_->SetDatabaseQuota(quota);
}
-void TestRunnerBindings::SetAlwaysAcceptCookies(bool accept) {
+void TestRunnerBindings::SetBlockThirdPartyCookies(bool block) {
if (runner_)
- runner_->SetAlwaysAcceptCookies(accept);
+ runner_->SetBlockThirdPartyCookies(block);
}
void TestRunnerBindings::SetWindowIsKey(bool value) {
@@ -2607,8 +2607,8 @@ void TestRunner::SetDatabaseQuota(int quota) {
delegate_->SetDatabaseQuota(quota);
}
-void TestRunner::SetAlwaysAcceptCookies(bool accept) {
- delegate_->SetAcceptAllCookies(accept);
+void TestRunner::SetBlockThirdPartyCookies(bool block) {
+ delegate_->SetAcceptAllCookies(!block);
Mike West 2016/07/05 08:42:23 Nit: Why not change the name up through the delega
tyoshino (SeeGerritForStatus) 2016/07/05 14:17:12 Done.
}
void TestRunner::SetFocus(blink::WebView* web_view, bool focus) {
« no previous file with comments | « components/test_runner/test_runner.h ('k') | third_party/WebKit/LayoutTests/http/tests/cookies/resources/resetCookies.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698