Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2125513002: chromium_build_stats: redirect login url if not logged in. (Closed)

Created:
4 years, 5 months ago by ukai
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

chromium_build_stats: redirect login url if not logged in. BUG=606647, 619718 Committed: https://chromium.googlesource.com/infra/infra/+/dc363e8dd39d08738324fb1f43caba38b6606317

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -31 lines) Patch
A appengine/chromium_build_stats/default/auth.go View 1 chunk +38 lines, -0 lines 0 comments Download
M appengine/chromium_build_stats/default/compiler_proxy_log.go View 2 chunks +22 lines, -5 lines 1 comment Download
M appengine/chromium_build_stats/default/ninja_log.go View 1 chunk +1 line, -26 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ukai
4 years, 5 months ago (2016-07-05 04:52:48 UTC) #3
Yoshisato Yanagisawa
lgtm w/ comment https://codereview.chromium.org/2125513002/diff/1/appengine/chromium_build_stats/default/compiler_proxy_log.go File appengine/chromium_build_stats/default/compiler_proxy_log.go (right): https://codereview.chromium.org/2125513002/diff/1/appengine/chromium_build_stats/default/compiler_proxy_log.go#newcode120 appengine/chromium_build_stats/default/compiler_proxy_log.go:120: if !strings.HasSuffix(u.Email, "@google.com") { maybe intended ...
4 years, 5 months ago (2016-07-05 05:00:05 UTC) #4
shinyak (Google)
lgtm
4 years, 5 months ago (2016-07-05 05:09:36 UTC) #6
tikuta
lgtm
4 years, 5 months ago (2016-07-05 06:07:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125513002/1
4 years, 5 months ago (2016-07-06 07:55:48 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 08:12:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/dc363e8dd39d08738324fb1f43cab...

Powered by Google App Engine
This is Rietveld 408576698