Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7193)

Unified Diff: chrome/browser/ui/webui/help/help_handler.cc

Issue 2125473002: Remove WebKit version from the About page on Chrome OS and the Blink version from chrome://version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: superfluous include Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/help/help_content.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/help/help_handler.cc
diff --git a/chrome/browser/ui/webui/help/help_handler.cc b/chrome/browser/ui/webui/help/help_handler.cc
index 7987e7187c1148e4a1a5a3b7a709f690e4a2cae0..3b6f306bcf0fd4ae8ffc19a7654c405db4e01890 100644
--- a/chrome/browser/ui/webui/help/help_handler.cc
+++ b/chrome/browser/ui/webui/help/help_handler.cc
@@ -46,7 +46,6 @@
#include "content/public/browser/notification_service.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
-#include "content/public/common/user_agent.h"
#include "grit/components_chromium_strings.h"
#include "grit/components_google_chrome_strings.h"
#include "grit/components_strings.h"
@@ -298,7 +297,6 @@ void HelpHandler::GetLocalizedValues(base::DictionaryValue* localized_strings) {
IDS_ABOUT_PAGE_CHANNEL_CHANGE_PAGE_CHANGE_BUTTON},
{"channelChangePageCancelButton",
IDS_ABOUT_PAGE_CHANNEL_CHANGE_PAGE_CANCEL_BUTTON},
- {"webkit", IDS_WEBKIT},
{"userAgent", IDS_VERSION_UI_USER_AGENT},
{"commandLine", IDS_VERSION_UI_COMMAND_LINE},
{"buildDate", IDS_VERSION_UI_BUILD_DATE},
@@ -378,8 +376,6 @@ void HelpHandler::GetLocalizedValues(base::DictionaryValue* localized_strings) {
IDS_ABOUT_TERMS_OF_SERVICE, base::UTF8ToUTF16(chrome::kChromeUITermsURL));
localized_strings->SetString("productTOS", tos);
- localized_strings->SetString("webkitVersion", content::GetWebKitVersion());
Dan Beam 2016/07/06 18:26:52 the number stays the same but the sha1 doesn't, i.
-
localized_strings->SetString("jsEngine", "V8");
localized_strings->SetString("jsEngineVersion", v8::V8::GetVersion());
« no previous file with comments | « chrome/browser/resources/help/help_content.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698