Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: net/url_request/url_request_http_job.h

Issue 212543005: Do not copy reference fragments for overridden redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address mmenke's comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_ 5 #ifndef NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
6 #define NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_ 6 #define NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 virtual LoadState GetLoadState() const OVERRIDE; 100 virtual LoadState GetLoadState() const OVERRIDE;
101 virtual UploadProgress GetUploadProgress() const OVERRIDE; 101 virtual UploadProgress GetUploadProgress() const OVERRIDE;
102 virtual bool GetMimeType(std::string* mime_type) const OVERRIDE; 102 virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
103 virtual bool GetCharset(std::string* charset) OVERRIDE; 103 virtual bool GetCharset(std::string* charset) OVERRIDE;
104 virtual void GetResponseInfo(HttpResponseInfo* info) OVERRIDE; 104 virtual void GetResponseInfo(HttpResponseInfo* info) OVERRIDE;
105 virtual void GetLoadTimingInfo( 105 virtual void GetLoadTimingInfo(
106 LoadTimingInfo* load_timing_info) const OVERRIDE; 106 LoadTimingInfo* load_timing_info) const OVERRIDE;
107 virtual bool GetResponseCookies(std::vector<std::string>* cookies) OVERRIDE; 107 virtual bool GetResponseCookies(std::vector<std::string>* cookies) OVERRIDE;
108 virtual int GetResponseCode() const OVERRIDE; 108 virtual int GetResponseCode() const OVERRIDE;
109 virtual Filter* SetupFilter() const OVERRIDE; 109 virtual Filter* SetupFilter() const OVERRIDE;
110 virtual bool IsRedirectFragmentModificationAllowed(
111 const GURL& location) const OVERRIDE;
110 virtual bool IsSafeRedirect(const GURL& location) OVERRIDE; 112 virtual bool IsSafeRedirect(const GURL& location) OVERRIDE;
111 virtual bool NeedsAuth() OVERRIDE; 113 virtual bool NeedsAuth() OVERRIDE;
112 virtual void GetAuthChallengeInfo(scoped_refptr<AuthChallengeInfo>*) OVERRIDE; 114 virtual void GetAuthChallengeInfo(scoped_refptr<AuthChallengeInfo>*) OVERRIDE;
113 virtual void SetAuth(const AuthCredentials& credentials) OVERRIDE; 115 virtual void SetAuth(const AuthCredentials& credentials) OVERRIDE;
114 virtual void CancelAuth() OVERRIDE; 116 virtual void CancelAuth() OVERRIDE;
115 virtual void ContinueWithCertificate(X509Certificate* client_cert) OVERRIDE; 117 virtual void ContinueWithCertificate(X509Certificate* client_cert) OVERRIDE;
116 virtual void ContinueDespiteLastError() OVERRIDE; 118 virtual void ContinueDespiteLastError() OVERRIDE;
117 virtual void ResumeNetworkStart() OVERRIDE; 119 virtual void ResumeNetworkStart() OVERRIDE;
118 virtual bool ReadRawData(IOBuffer* buf, int buf_size, 120 virtual bool ReadRawData(IOBuffer* buf, int buf_size,
119 int* bytes_read) OVERRIDE; 121 int* bytes_read) OVERRIDE;
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 base::WeakPtrFactory<URLRequestHttpJob> weak_factory_; 252 base::WeakPtrFactory<URLRequestHttpJob> weak_factory_;
251 253
252 CompletionCallback on_headers_received_callback_; 254 CompletionCallback on_headers_received_callback_;
253 255
254 // We allow the network delegate to modify a copy of the response headers. 256 // We allow the network delegate to modify a copy of the response headers.
255 // This prevents modifications of headers that are shared with the underlying 257 // This prevents modifications of headers that are shared with the underlying
256 // layers of the network stack. 258 // layers of the network stack.
257 scoped_refptr<HttpResponseHeaders> override_response_headers_; 259 scoped_refptr<HttpResponseHeaders> override_response_headers_;
258 260
259 // The network delegate can mark a URL as safe for redirection. 261 // The network delegate can mark a URL as safe for redirection.
262 // Reference fragment are not attached to the redirect URL if this URL is
mmenke 2014/04/01 20:26:51 nit: fragment->fragments (Or "The reference fragm
robwu 2014/04/01 20:46:33 Done.
263 // equal to |allowed_unsafe_redirect_url_|.
260 GURL allowed_unsafe_redirect_url_; 264 GURL allowed_unsafe_redirect_url_;
261 265
262 // Flag used to verify that |this| is not deleted while we are awaiting 266 // Flag used to verify that |this| is not deleted while we are awaiting
263 // a callback from the NetworkDelegate. Used as a fail-fast mechanism. 267 // a callback from the NetworkDelegate. Used as a fail-fast mechanism.
264 // True if we are waiting a callback and 268 // True if we are waiting a callback and
265 // NetworkDelegate::NotifyURLRequestDestroyed has not been called, yet, 269 // NetworkDelegate::NotifyURLRequestDestroyed has not been called, yet,
266 // to inform the NetworkDelegate that it may not call back. 270 // to inform the NetworkDelegate that it may not call back.
267 bool awaiting_callback_; 271 bool awaiting_callback_;
268 272
269 const HttpUserAgentSettings* http_user_agent_settings_; 273 const HttpUserAgentSettings* http_user_agent_settings_;
270 274
271 DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob); 275 DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob);
272 }; 276 };
273 277
274 } // namespace net 278 } // namespace net
275 279
276 #endif // NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_ 280 #endif // NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698