Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212543003: CSS Transforms: Implement transform (Closed)

Created:
6 years, 9 months ago by dstockwell
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, Steve Block, rwlbuis, dino_apple.com, alancutter (OOO until 2018), bemjb+rendering_chromium.org, dsinclair, Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink, Eric Willigers, rjwright, zoltan1, darktears, leviw+renderwatch, Mike Lawther (Google), ed+blinkwatch_opera.com, eseidel, esprehn, ojan, Julien - ping for review
Visibility:
Public.

Description

CSS Transforms: Implement transform Implements transform as defined in CSS Transforms[1]. Behavior is similar to -webkit-transform, but the perspective() function is not allowed to contain numbers without units. Like -webkit-transform and other user agents, the resolved value of transform is not the computed value as currently defined by css-transitions[2]. The animation system is modified to avoid running animations and transitions on both the prefixed and unprefixed variants at the same time. Internally, animations are mapped to the unprefixed variant. As animations operate directly on the RenderStyle storage the result of specifying an animation/transition on either property is the same. Note, this property is guarded by the CSSTransformsUnprefixed runtime feature (enabled only for testing). [1] http://www.w3.org/TR/css3-transforms/ [2] http://lists.w3.org/Archives/Public/www-style/2013Dec/0317.html BUG=154772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170527

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1029 lines, -657 lines) Patch
M LayoutTests/animations/interpolation/transform-interpolation.html View 48 chunks +48 lines, -48 lines 0 comments Download
M LayoutTests/animations/interpolation/transform-interpolation-expected.txt View 1 chunk +576 lines, -576 lines 0 comments Download
A + LayoutTests/animations/interpolation/webkit-transform-interpolation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/animations/interpolation/webkit-transform-interpolation-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/transforms/transform-parsing.html View 1 chunk +192 lines, -0 lines 0 comments Download
A LayoutTests/transforms/transform-parsing-expected.txt View 1 chunk +148 lines, -0 lines 0 comments Download
A + LayoutTests/transitions/unprefixed-transform.html View 3 2 chunks +8 lines, -4 lines 0 comments Download
A LayoutTests/transitions/unprefixed-transform-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/animation/ActiveAnimations.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTest.cpp View 3 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 4 chunks +3 lines, -1 line 0 comments Download
M Source/core/css/CSSMatrix.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 5 chunks +7 lines, -6 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/animation/KeyframeValueList.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (0 generated)
dstockwell
Depends on https://codereview.chromium.org/211233003/ This patch looks large, but the delta within Source/core is less than ...
6 years, 9 months ago (2014-03-26 09:53:27 UTC) #1
eseidel
lgtm
6 years, 9 months ago (2014-03-27 23:18:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212543003/1
6 years, 9 months ago (2014-03-27 23:18:08 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:18:46 UTC) #4
commit-bot: I haz the power
Failed to apply patch for LayoutTests/transitions/unprefixed-transform.html: While running svn copy LayoutTests/transitions/unprefixed-perspective.html LayoutTests/transitions/unprefixed-transform.html --config-dir /b/commit-queue/subversion_config --non-interactive ...
6 years, 9 months ago (2014-03-27 23:18:46 UTC) #5
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 14:19:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212543003/50001
6 years, 9 months ago (2014-03-28 14:19:52 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 14:45:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-28 14:45:31 UTC) #9
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 14:47:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212543003/50001
6 years, 9 months ago (2014-03-28 14:47:10 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 15:30:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 15:30:47 UTC) #13
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 19:07:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212543003/50001
6 years, 9 months ago (2014-03-28 19:07:23 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 20:17:01 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 20:17:02 UTC) #17
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 9 months ago (2014-03-28 20:32:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212543003/50001
6 years, 9 months ago (2014-03-28 20:32:18 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 20:43:42 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 20:43:43 UTC) #21
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 8 months ago (2014-04-01 01:47:12 UTC) #22
dstockwell
The CQ bit was unchecked by dstockwell@chromium.org
6 years, 8 months ago (2014-04-01 01:47:16 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212543003/50001
6 years, 8 months ago (2014-04-01 01:47:16 UTC) #24
dstockwell
The CQ bit was unchecked by dstockwell@chromium.org
6 years, 8 months ago (2014-04-01 01:47:25 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 01:47:27 UTC) #26
commit-bot: I haz the power
Failed to apply patch for LayoutTests/transitions/unprefixed-transform.html: While running svn copy LayoutTests/transitions/unprefixed-perspective.html LayoutTests/transitions/unprefixed-transform.html --config-dir /b/commit-queue/subversion_config --non-interactive ...
6 years, 8 months ago (2014-04-01 01:47:28 UTC) #27
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 8 months ago (2014-04-01 06:34:35 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212543003/90001
6 years, 8 months ago (2014-04-01 06:34:40 UTC) #29
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 06:45:01 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 06:45:01 UTC) #31
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 8 months ago (2014-04-01 07:03:53 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/212543003/90001
6 years, 8 months ago (2014-04-01 07:03:55 UTC) #33
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 07:44:24 UTC) #34
Message was sent while issue was closed. 
Change committed as 170527

Powered by Google App Engine
This is Rietveld 408576698