Make sure moved-from SpdyHeaderBlock instances are valid.

Make sure moved-from SpdyHeaderBlock instances are valid.

* Introduce lazy allocation of Storage.  This in particular allows moved-from
SpdyHeaderBlock instances to be valid without having to allocate Storage for
them.
* Use swap in move constructor and move assignment operator to make sure
moved-from instance is valid.
* Add SpdyHeaderBlockTest.MovedFromIsValid test.
* s/block1/block/ in SpdyHeaderBlockTest.AddHeaders.

This CL lands server change 125821596 by bnc.

BUG=488484
Committed: https://crrev.com/fdcd9441c6a62f381878d6bd5ffe408077263218
Cr-Commit-Position: refs/heads/master@{#404481}

[yinjie, 2016-07-07 21:26:15]

The CQ bit was checked by yinjie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 21:27:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yinjie, 2016-07-07 22:49:27]

Description was changed from

==========
Fix test code conflicts


Fix compile error


Make sure moved-from SpdyHeaderBlock instances are valid.

* Introduce lazy allocation of Storage.  This in particular allows moved-from
SpdyHeaderBlock instances to be valid without having to allocate Storage for
them.
* Use swap in move constructor and move assignment operator to make sure
moved-from instance is valid.
* Add SpdyHeaderBlockTest.MovedFromIsValid test.
* s/block1/block/ in SpdyHeaderBlockTest.AddHeaders.

This CL lands server change 125821596 by bnc.

BUG=488484
==========

to

==========
Make sure moved-from SpdyHeaderBlock instances are valid.

* Introduce lazy allocation of Storage.  This in particular allows moved-from
SpdyHeaderBlock instances to be valid without having to allocate Storage for
them.
* Use swap in move constructor and move assignment operator to make sure
moved-from instance is valid.
* Add SpdyHeaderBlockTest.MovedFromIsValid test.
* s/block1/block/ in SpdyHeaderBlockTest.AddHeaders.

This CL lands server change 125821596 by bnc.

BUG=488484
==========

[yinjie, 2016-07-07 22:49:27]

yinjie@chromium.org changed reviewers:
+ bnc@chromium.org

[commit-bot: I haz the power, 2016-07-07 23:30:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 23:30:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[yinjie, 2016-07-08 00:28:19]

The CQ bit was checked by yinjie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 00:29:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 01:03:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 01:03:25]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-07-08 20:13:40]

LGTM.

[yinjie, 2016-07-08 20:24:29]

The CQ bit was checked by yinjie@chromium.org

[commit-bot: I haz the power, 2016-07-08 20:24:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 20:31:15]

Description was changed from

==========
Make sure moved-from SpdyHeaderBlock instances are valid.

* Introduce lazy allocation of Storage.  This in particular allows moved-from
SpdyHeaderBlock instances to be valid without having to allocate Storage for
them.
* Use swap in move constructor and move assignment operator to make sure
moved-from instance is valid.
* Add SpdyHeaderBlockTest.MovedFromIsValid test.
* s/block1/block/ in SpdyHeaderBlockTest.AddHeaders.

This CL lands server change 125821596 by bnc.

BUG=488484
==========

to

==========
Make sure moved-from SpdyHeaderBlock instances are valid.

* Introduce lazy allocation of Storage.  This in particular allows moved-from
SpdyHeaderBlock instances to be valid without having to allocate Storage for
them.
* Use swap in move constructor and move assignment operator to make sure
moved-from instance is valid.
* Add SpdyHeaderBlockTest.MovedFromIsValid test.
* s/block1/block/ in SpdyHeaderBlockTest.AddHeaders.

This CL lands server change 125821596 by bnc.

BUG=488484
==========

[commit-bot: I haz the power, 2016-07-08 20:31:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-08 20:32:33]

Description was changed from

==========
Make sure moved-from SpdyHeaderBlock instances are valid.

* Introduce lazy allocation of Storage.  This in particular allows moved-from
SpdyHeaderBlock instances to be valid without having to allocate Storage for
them.
* Use swap in move constructor and move assignment operator to make sure
moved-from instance is valid.
* Add SpdyHeaderBlockTest.MovedFromIsValid test.
* s/block1/block/ in SpdyHeaderBlockTest.AddHeaders.

This CL lands server change 125821596 by bnc.

BUG=488484
==========

to

==========
Make sure moved-from SpdyHeaderBlock instances are valid.

* Introduce lazy allocation of Storage.  This in particular allows moved-from
SpdyHeaderBlock instances to be valid without having to allocate Storage for
them.
* Use swap in move constructor and move assignment operator to make sure
moved-from instance is valid.
* Add SpdyHeaderBlockTest.MovedFromIsValid test.
* s/block1/block/ in SpdyHeaderBlockTest.AddHeaders.

This CL lands server change 125821596 by bnc.

BUG=488484

Committed: https://crrev.com/fdcd9441c6a62f381878d6bd5ffe408077263218
Cr-Commit-Position: refs/heads/master@{#404481}
==========

[commit-bot: I haz the power, 2016-07-08 20:32:34]

Patchset 1 (id:??) landed as
https://crrev.com/fdcd9441c6a62f381878d6bd5ffe408077263218
Cr-Commit-Position: refs/heads/master@{#404481}