Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2125383002: Revert of Embed address normalization rewriting rules. (Closed)

Created:
4 years, 5 months ago by Mathieu
Modified:
4 years, 5 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Embed address normalization rewriting rules. (patchset #3 id:80001 of https://codereview.chromium.org/2121253002/ ) Reason for revert: Some merging logic could trigger DCHECK on debug builds. Will reland with fix. Original issue's description: > Embed address normalization rewriting rules. > > This CL adds a table of string rewrite rules, keyed by country > code, to aid in address normalization when comparing autofill > profiles. > > The rules for each country code are stored as static constant > string tables and compiled to regular expression replacement > params on first use, and subsequently cached. > > R=mathp@chromium.org, sebsg@chromium.org > BUG=618095 > > Committed: https://crrev.com/0d2a71a993405545d9a735e5a8d5807815ee24c2 > Cr-Commit-Position: refs/heads/master@{#404158} TBR=sebsg@chromium.org,rogerm@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618095 Committed: https://crrev.com/fabd01ea0d0b0f9822e18ba5f375568a262ec697 Cr-Commit-Position: refs/heads/master@{#404218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4000 lines) Patch
M components/autofill.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D components/autofill/core/browser/address_rewriter.h View 1 chunk +0 lines, -64 lines 0 comments Download
D components/autofill/core/browser/address_rewriter.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D components/autofill/core/browser/address_rewriter_rules.cc View 1 chunk +0 lines, -3500 lines 0 comments Download
D components/autofill/core/browser/address_rewriter_unittest.cc View 1 chunk +0 lines, -284 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_comparator.h View 1 chunk +6 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_profile_comparator.cc View 7 chunks +34 lines, -15 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mathieu
Created Revert of Embed address normalization rewriting rules.
4 years, 5 months ago (2016-07-07 19:47:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125383002/1
4 years, 5 months ago (2016-07-07 19:48:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 19:49:00 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 19:49:04 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:50:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fabd01ea0d0b0f9822e18ba5f375568a262ec697
Cr-Commit-Position: refs/heads/master@{#404218}

Powered by Google App Engine
This is Rietveld 408576698