Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2125373002: mash: Migrate ash/system/user to ash/common. (Closed)

Created:
4 years, 5 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Migrate ash/system/user to ash/common. "git rm ash/common/system/user/DEPS" (no longer needed) tools/git/move_source_file.py ash/system/user/* ash/common/system/user tools/git/move_source_file.py ash/ash_view_ids.h ash/common/ Also, update tray_user_unittest.cc to only use ash/common code. BUG=619636 TEST=compiles; unit tests; no behavior changes. R=jamescook@chromium.org Committed: https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109 Cr-Commit-Position: refs/heads/master@{#404240}

Patch Set 1 #

Patch Set 2 : Sync and rebase. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1819 lines) Patch
M ash/ash.gyp View 4 chunks +7 lines, -7 lines 0 comments Download
D ash/ash_view_ids.h View 1 chunk +0 lines, -18 lines 0 comments Download
A + ash/common/ash_view_ids.h View 2 chunks +3 lines, -3 lines 1 comment Download
A + ash/common/system/user/tray_user.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/user/tray_user.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/common/system/user/tray_user_unittest.cc View 7 chunks +8 lines, -10 lines 0 comments Download
A + ash/common/system/user/user_card_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/user/user_card_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/common/system/user/user_view.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/system/user/user_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/media_security/multi_profile_media_tray_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/user/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ash/system/user/tray_user.h View 1 chunk +0 lines, -96 lines 0 comments Download
D ash/system/user/tray_user.cc View 1 chunk +0 lines, -271 lines 0 comments Download
D ash/system/user/tray_user_unittest.cc View 1 chunk +0 lines, -270 lines 0 comments Download
D ash/system/user/user_card_view.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ash/system/user/user_card_view.cc View 1 chunk +0 lines, -450 lines 0 comments Download
D ash/system/user/user_view.h View 1 chunk +0 lines, -107 lines 0 comments Download
D ash/system/user/user_view.cc View 1 chunk +0 lines, -521 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
msw
Hey James, please take a look; thanks!
4 years, 5 months ago (2016-07-07 19:35:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125373002/20001
4 years, 5 months ago (2016-07-07 19:58:48 UTC) #3
James Cook
LGTM - hooray! https://codereview.chromium.org/2125373002/diff/20001/ash/common/ash_view_ids.h File ash/common/ash_view_ids.h (right): https://codereview.chromium.org/2125373002/diff/20001/ash/common/ash_view_ids.h#newcode12 ash/common/ash_view_ids.h:12: VIEW_ID_MEDIA_TRAY_VIEW, aside: Ugh, this feels so ...
4 years, 5 months ago (2016-07-07 20:19:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 21:53:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125373002/20001
4 years, 5 months ago (2016-07-07 21:59:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 22:06:43 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 22:06:54 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 22:08:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109
Cr-Commit-Position: refs/heads/master@{#404240}

Powered by Google App Engine
This is Rietveld 408576698