Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: runtime/observatory/HACKING.md

Issue 2125343002: Ban cross origin WebSocket connections to the service protocol (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: skybrian review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/bin/vmservice_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Hacking Observatory 1 # Hacking Observatory
2 2
3 These instructions will guide you through the Observatory development and 3 These instructions will guide you through the Observatory development and
4 testing workflow. 4 testing workflow.
5 5
6 ## SDK Setup & Build 6 ## SDK Setup & Build
7 Getting ready to start. 7 Getting ready to start.
8 8
9 Before you start to hack on Observatory, follow the [instructions][build_sdk] to 9 Before you start to hack on Observatory, follow the [instructions][build_sdk] to
10 have a working environment in which you are able to build and test the Dart SDK. 10 have a working environment in which you are able to build and test the Dart SDK.
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 main() { 62 main() {
63 bool tick = true; 63 bool tick = true;
64 new Timer.periodic(const Duration(seconds: 1), (Timer t) { 64 new Timer.periodic(const Duration(seconds: 1), (Timer t) {
65 print(tick ? 'tick' : 'tock'); 65 print(tick ? 'tick' : 'tock');
66 tick = !tick; 66 tick = !tick;
67 }); 67 });
68 } 68 }
69 ``` 69 ```
70 Start the script: 70 Start the script:
71 ``` 71 ```
72 $ dart --observe clock.dart 72 $ dart --disable-service-origin-check --observe clock.dart
73 ``` 73 ```
74 74
75 ## Code Reviews 75 ## Code Reviews
76 The development workflow of Dart (and Observatory) is based on code reviews. 76 The development workflow of Dart (and Observatory) is based on code reviews.
77 77
78 Follow the code review [instructions][code_review] to be able to successfully 78 Follow the code review [instructions][code_review] to be able to successfully
79 submit your code. 79 submit your code.
80 80
81 The main reviewers for Observatory related CLs are: 81 The main reviewers for Observatory related CLs are:
82 - turnidge 82 - turnidge
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 ## Run your tests 184 ## Run your tests
185 See: __Run existing tests__ 185 See: __Run existing tests__
186 186
187 [build_sdk]: https://github.com/dart-lang/sdk/wiki/Building "Building the Dart S DK" 187 [build_sdk]: https://github.com/dart-lang/sdk/wiki/Building "Building the Dart S DK"
188 [download_dartium]: https://www.dartlang.org/tools/dartium/ "Download Dartium" 188 [download_dartium]: https://www.dartlang.org/tools/dartium/ "Download Dartium"
189 [build_dartium]: https://github.com/dart-lang/sdk/wiki/Building-Dartium "Build D artium" 189 [build_dartium]: https://github.com/dart-lang/sdk/wiki/Building-Dartium "Build D artium"
190 [open_observatory]: http://localhost:8080/ "Open Observatory" 190 [open_observatory]: http://localhost:8080/ "Open Observatory"
191 [observatory_get_started]: https://dart-lang.github.io/observatory/get-started.h tml "Observatory get started" 191 [observatory_get_started]: https://dart-lang.github.io/observatory/get-started.h tml "Observatory get started"
192 [code_review]: https://github.com/dart-lang/sdk/wiki/Code-review-workflow-with-G itHub-and-reitveld "Code Review" 192 [code_review]: https://github.com/dart-lang/sdk/wiki/Code-review-workflow-with-G itHub-and-reitveld "Code Review"
193 [test_library]: https://pub.dartlang.org/packages/test "Test Library" 193 [test_library]: https://pub.dartlang.org/packages/test "Test Library"
OLDNEW
« no previous file with comments | « runtime/bin/vmservice_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698