Add chrome-side code for autoreload experiment.

Add chrome-side code for autoreload experiment.

In ChromeContentBrowserClient, check for membership in the trial group, and if the autoreload field trial is enabled, set the renderer command-line flag to enable it.

BUG=355569
TEST=unit,trybot

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260238

[mmenke, 2014-03-26 15:26:18]

LGTM

[Elly Fong-Jones, 2014-03-28 14:30:39]

On 2014/03/26 15:26:18, mmenke wrote:
> LGTM

I changed this CL to check for the experiment in the browser instead of the
renderer. Apparently, unless the experiment has been first used in the browser,
its value doesn't propagate down to renderer processes, so I decided to just
move the only use up into the browser.

PTAL?

[mmenke, 2014-03-28 14:54:01]

LGTM

https://codereview.chromium.org/212533004/diff/1/chrome/renderer/net/net_erro...
File chrome/renderer/net/net_error_helper.cc (right):

https://codereview.chromium.org/212533004/diff/1/chrome/renderer/net/net_erro...
chrome/renderer/net/net_error_helper.cc:92: bool auto_reload_enabled = false;
nit:  Do we really need this bool?

https://codereview.chromium.org/212533004/diff/1/chrome/renderer/net/net_erro...
chrome/renderer/net/net_error_helper.cc:95:
command_line->HasSwitch(switches::kEnableOfflineAutoReload))
nit:  Use braces {} when if statement+body takes up more than 2 lines.

https://codereview.chromium.org/212533004/diff/30001/chrome/browser/chrome_co...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/212533004/diff/30001/chrome/browser/chrome_co...
chrome/browser/chrome_content_browser_client.cc:1558:
command_line->AppendSwitch(switches::kEnableOfflineAutoReload);
nit:  +braces

https://codereview.chromium.org/212533004/diff/30001/chrome/renderer/net/net_...
File chrome/renderer/net/net_error_helper.cc (right):

https://codereview.chromium.org/212533004/diff/30001/chrome/renderer/net/net_...
chrome/renderer/net/net_error_helper.cc:12: #include
"base/metrics/field_trial.h"
nit:  Not needed.

[Elly Fong-Jones, 2014-03-28 15:23:37]

https://codereview.chromium.org/212533004/diff/30001/chrome/browser/chrome_co...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/212533004/diff/30001/chrome/browser/chrome_co...
chrome/browser/chrome_content_browser_client.cc:1558:
command_line->AppendSwitch(switches::kEnableOfflineAutoReload);
On 2014/03/28 14:54:02, mmenke wrote:
> nit:  +braces

Done.

https://codereview.chromium.org/212533004/diff/30001/chrome/renderer/net/net_...
File chrome/renderer/net/net_error_helper.cc (right):

https://codereview.chromium.org/212533004/diff/30001/chrome/renderer/net/net_...
chrome/renderer/net/net_error_helper.cc:12: #include
"base/metrics/field_trial.h"
On 2014/03/28 14:54:02, mmenke wrote:
> nit:  Not needed.

Done.

[Elly Fong-Jones, 2014-03-28 15:23:54]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2014-03-28 15:27:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ellyjones@chromium.org/212533004/50001

[commit-bot: I haz the power, 2014-03-28 19:29:10]

Change committed as 260238