|
|
Use overloaded operators with QuicTime for addition, subtraction and scalar
multiplication. No functional change.
This change removes Add, Subtract and Multiply methods from QuicTime and
QuicTime::Delta and introduces the corresponding overloads for operators "+",
"-" and "*". They behave in a manner that is "obvious, unsurprising, and
consistent with the corresponding built-in operators".
The goal here is to both to improve code readability, and to allow polymorphism
between QuicTime and integral types in certain contexts.
Merge internal change: 126407046
R=rch@chromium.org
BUG=
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+416 lines, -416 lines) |
Patch |
 |
M |
net/quic/congestion_control/cubic.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/cubic_bytes.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/general_loss_algorithm.cc
|
View
|
|
4 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/general_loss_algorithm_test.cc
|
View
|
|
14 chunks |
+28 lines, -28 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/hybrid_slow_start.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/hybrid_slow_start_test.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/pacing_sender.cc
|
View
|
|
3 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/rtt_stats.cc
|
View
|
|
3 chunks |
+6 lines, -8 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/rtt_stats_test.cc
|
View
|
|
2 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/send_algorithm_simulator.cc
|
View
|
|
6 chunks |
+13 lines, -14 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/tcp_cubic_sender_base.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/windowed_filter.h
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
net/quic/congestion_control/windowed_filter_test.cc
|
View
|
|
16 chunks |
+30 lines, -30 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_alarm.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/quic/quic_alarm_test.cc
|
View
|
|
7 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_buffered_packet_store.cc
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_buffered_packet_store_test.cc
|
View
|
|
3 chunks |
+7 lines, -8 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_chromium_alarm_factory.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/quic/quic_chromium_alarm_factory_test.cc
|
View
|
|
10 chunks |
+21 lines, -24 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_chromium_packet_reader.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/quic/quic_client_promised_info.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_clock.cc
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_connection.cc
|
View
|
|
9 chunks |
+15 lines, -16 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_connection_logger.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/quic/quic_connection_test.cc
|
View
|
|
35 chunks |
+51 lines, -51 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_flow_controller.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_framer.cc
|
View
|
|
4 chunks |
+8 lines, -9 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_framer_test.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/quic/quic_headers_stream.cc
|
View
|
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_protocol_test.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/quic/quic_received_packet_manager.cc
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_received_packet_manager_test.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_sent_packet_manager.cc
|
View
|
|
5 chunks |
+11 lines, -12 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_sent_packet_manager_test.cc
|
View
|
|
13 chunks |
+17 lines, -17 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_server_session_base.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/quic/quic_server_session_base_test.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_sustained_bandwidth_recorder.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/quic/quic_sustained_bandwidth_recorder_test.cc
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_time.h
|
View
|
|
4 chunks |
+47 lines, -32 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_time_test.cc
|
View
|
|
5 chunks |
+24 lines, -21 lines |
0 comments
|
Download
|
|
M |
net/quic/quic_unacked_packet_map_test.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/quic/test_tools/mock_clock.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
net/tools/quic/quic_epoll_alarm_factory.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
net/tools/quic/quic_epoll_alarm_factory_test.cc
|
View
|
|
4 chunks |
+16 lines, -19 lines |
0 comments
|
Download
|
|
M |
net/tools/quic/quic_epoll_clock.cc
|
View
|
|
2 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
net/tools/quic/quic_epoll_clock_test.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
net/tools/quic/quic_epoll_connection_helper_test.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/tools/quic/quic_socket_utils.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/tools/quic/quic_time_wait_list_manager.cc
|
View
|
|
3 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
|
M |
net/tools/quic/quic_time_wait_list_manager_test.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
net/tools/quic/test_tools/packet_dropping_test_writer.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
net/tools/quic/test_tools/quic_test_client.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
Depends on Patchset:
Dependent Patchsets:
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
2125303002:
Use overloaded operators with QuicTime for addition, subtraction and scalar (Closed)
