Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2125293002: Revert of gpu: Use a VAO as required by the core profile in ClearFramebuffer (Closed)

Created:
4 years, 5 months ago by Corentin Wallez
Modified:
4 years, 5 months ago
Reviewers:
Zhenyao Mo, Geoff Lang
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: Use a VAO as required by the core profile in ClearFramebuffer (patchset #2 id:20001 of https://codereview.chromium.org/2080943002/ ) Reason for revert: Causes an assert in the IMG GPU driver in Android 4.4 Original issue's description: > gpu: Use a VAO as required by the core profile in ClearFramebuffer > > glVertexAttribPointer requires that a VAO is bound when using the OpenGL > core profile. > > BUG=598902 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/61e2da5b097776feecc81890cc68bc3f57172a08 > Cr-Commit-Position: refs/heads/master@{#401097} TBR=geofflang@chromium.org,zmo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=598902 BUG=624906 Committed: https://crrev.com/45cef81b7da79546b6c7d2863af16647d6640b4c Cr-Commit-Position: refs/heads/master@{#404215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -46 lines) Patch
M gpu/command_buffer/service/gles2_cmd_clear_framebuffer.h View 4 chunks +2 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc View 6 chunks +11 lines, -37 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Corentin Wallez
Created Revert of gpu: Use a VAO as required by the core profile in ClearFramebuffer
4 years, 5 months ago (2016-07-07 13:35:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125293002/1
4 years, 5 months ago (2016-07-07 13:35:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125293002/1
4 years, 5 months ago (2016-07-07 18:41:47 UTC) #6
boliu
add crbug.com/624906 to bug list so it's easy to request merge?
4 years, 5 months ago (2016-07-07 18:52:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 19:46:15 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:48:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45cef81b7da79546b6c7d2863af16647d6640b4c
Cr-Commit-Position: refs/heads/master@{#404215}

Powered by Google App Engine
This is Rietveld 408576698