Chromium Code Reviews
DescriptionRevert of Fix InputImeApiTest.SendKeyEventsOnNormalPage trybot failure. (patchset #4 id:60001 of https://codereview.chromium.org/2120823003/ )
Reason for revert:
Revert the working around.
The bug has been marked as blocked on bug:456420.
Original issue's description:
> InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot.
>
> This test is used to test that input.ime.sendKeyEvents API has limitations on some special pages. It fails on Site Isolation Linux FYI bot, as the test fails to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test environment. It tests under GURL(kChromeSearchLocalNtpUrl): chrome-search://local-ntp/local-ntp.html, which is special page for input.ime.sendKeyEvents.
>
> Fix this by not testing the API if the url has not been correctly set.
>
> BUG=624958
> TEST=None
>
> Committed: https://crrev.com/923f91436b01b92825d1998f18b344d151850ad3
> Cr-Commit-Position: refs/heads/master@{#403641}
TBR=shuchen@chromium.org,rdevlin.cronin@chromium.org,creis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=624958
Committed: https://crrev.com/2ca6e4ad757d0073e2e3de255dc10ca92a91a843
Cr-Commit-Position: refs/heads/master@{#404088}
Patch Set 1 #Patch Set 2 : Fix patch error. #Patch Set 3 : Typo: SendKeyEvntsOnNormalPage->SendKeyEventsOnNormalPage #
Messages
Total messages: 12 (5 generated)
|
||||||||||||||||||||||||||||