Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2125243002: Revert of Fix InputImeApiTest.SendKeyEventsOnNormalPage trybot failure. (Closed)

Created:
4 years, 5 months ago by Azure Wei
Modified:
4 years, 5 months ago
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, tfarina, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix InputImeApiTest.SendKeyEventsOnNormalPage trybot failure. (patchset #4 id:60001 of https://codereview.chromium.org/2120823003/ ) Reason for revert: Revert the working around. The bug has been marked as blocked on bug:456420. Original issue's description: > InputImeApiTest.SendKeyEventsOnNormalPage fails on Site Isolation Linux FYI bot. > > This test is used to test that input.ime.sendKeyEvents API has limitations on some special pages. It fails on Site Isolation Linux FYI bot, as the test fails to navigate the right test url: GRUL(chrome::kChromeUINewTabURL) in the test environment. It tests under GURL(kChromeSearchLocalNtpUrl): chrome-search://local-ntp/local-ntp.html, which is special page for input.ime.sendKeyEvents. > > Fix this by not testing the API if the url has not been correctly set. > > BUG=624958 > TEST=None > > Committed: https://crrev.com/923f91436b01b92825d1998f18b344d151850ad3 > Cr-Commit-Position: refs/heads/master@{#403641} TBR=shuchen@chromium.org,rdevlin.cronin@chromium.org,creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624958 Committed: https://crrev.com/2ca6e4ad757d0073e2e3de255dc10ca92a91a843 Cr-Commit-Position: refs/heads/master@{#404088}

Patch Set 1 #

Patch Set 2 : Fix patch error. #

Patch Set 3 : Typo: SendKeyEvntsOnNormalPage->SendKeyEventsOnNormalPage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -39 lines) Patch
M chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc View 1 2 5 chunks +21 lines, -39 lines 0 comments Download
M testing/buildbot/filters/site-per-process.browser_tests.filter View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Azure Wei
Created Revert of Fix InputImeApiTest.SendKeyEventsOnNormalPage trybot failure.
4 years, 5 months ago (2016-07-07 02:02:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125243002/1
4 years, 5 months ago (2016-07-07 02:03:36 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/197321) ios-device on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-07 02:06:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125243002/90001
4 years, 5 months ago (2016-07-07 04:49:22 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:90001)
4 years, 5 months ago (2016-07-07 05:52:38 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 05:52:40 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 05:54:41 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ca6e4ad757d0073e2e3de255dc10ca92a91a843
Cr-Commit-Position: refs/heads/master@{#404088}

Powered by Google App Engine
This is Rietveld 408576698