Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2125233003: [Editing][CodeHealth] assert_selection test doesn't need to have element. (Closed)

Created:
4 years, 5 months ago by yoichio
Modified:
4 years, 5 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

assert_selection test doesn't need to have element. Let assert_selection create body element so that each assert_selection test doesn't need to have element before the script. TEST=LayoutTests/editing/assert_selection.html Committed: https://crrev.com/553fb62bcbd4e88e1409eee669944dbb916b8807 Cr-Commit-Position: refs/heads/master@{#404109}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/editing/assert_selection.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/assert_selection.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
yoichio
4 years, 5 months ago (2016-07-07 05:43:56 UTC) #3
yosin_UTC9
lgtm w/ nit https://codereview.chromium.org/2125233003/diff/1/third_party/WebKit/LayoutTests/editing/assert_selection.js File third_party/WebKit/LayoutTests/editing/assert_selection.js (right): https://codereview.chromium.org/2125233003/diff/1/third_party/WebKit/LayoutTests/editing/assert_selection.js#newcode512 third_party/WebKit/LayoutTests/editing/assert_selection.js:512: document.body = document.createElement("body"); Let's check whether ...
4 years, 5 months ago (2016-07-07 05:55:48 UTC) #4
yoichio
https://codereview.chromium.org/2125233003/diff/1/third_party/WebKit/LayoutTests/editing/assert_selection.js File third_party/WebKit/LayoutTests/editing/assert_selection.js (right): https://codereview.chromium.org/2125233003/diff/1/third_party/WebKit/LayoutTests/editing/assert_selection.js#newcode512 third_party/WebKit/LayoutTests/editing/assert_selection.js:512: document.body = document.createElement("body"); On 2016/07/07 05:55:48, Yosi_UTC9 wrote: > ...
4 years, 5 months ago (2016-07-07 06:42:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125233003/20001
4 years, 5 months ago (2016-07-07 06:42:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 09:20:04 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 09:20:09 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 09:21:40 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/553fb62bcbd4e88e1409eee669944dbb916b8807
Cr-Commit-Position: refs/heads/master@{#404109}

Powered by Google App Engine
This is Rietveld 408576698