Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2296)

Unified Diff: content/child/indexed_db/indexed_db_dispatcher.cc

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime
Patch Set: Post dmurph review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/indexed_db/indexed_db_dispatcher.cc
diff --git a/content/child/indexed_db/indexed_db_dispatcher.cc b/content/child/indexed_db/indexed_db_dispatcher.cc
index 7d6196c637d58a625027c509e93055c00d1588d4..2d7ed9dd7d94948ebbd0eaf8dd659479badf7909 100644
--- a/content/child/indexed_db/indexed_db_dispatcher.cc
+++ b/content/child/indexed_db/indexed_db_dispatcher.cc
@@ -156,6 +156,7 @@ void IndexedDBDispatcher::OnMessageReceived(const IPC::Message& msg) {
OnVersionChange)
IPC_MESSAGE_HANDLER(IndexedDBMsg_DatabaseCallbacksAbort, OnAbort)
IPC_MESSAGE_HANDLER(IndexedDBMsg_DatabaseCallbacksComplete, OnComplete)
+ IPC_MESSAGE_HANDLER(IndexedDBMsg_DatabaseCallbacksChanges, OnDatabaseChange)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
// If a message gets here, IndexedDBMessageFilter already determined that it
@@ -797,6 +798,17 @@ void IndexedDBDispatcher::OnComplete(int32_t ipc_thread_id,
callbacks->onComplete(transaction_id);
}
+void IndexedDBDispatcher::OnDatabaseChange(
+ int32_t ipc_thread_id,
+ int32_t ipc_database_callbacks_id,
+ const IndexedDBObserverChanges& changes_map) {
+ // for(auto& obs: changes_map.observation_index) {
dmurph 2016/07/08 23:51:40 Ah, so here we'll probably want to decompose to ea
palakj1 2016/07/11 05:33:26 Done.
+ // WebIDBObserver* observer = observers_.Lookup(obs.first);
+ // // Can shift this logic to blink.
+ //// observer->onChange(changes_map.observations, std::move(obs.second));
+ // }
+}
+
void IndexedDBDispatcher::OnForcedClose(int32_t ipc_thread_id,
int32_t ipc_database_callbacks_id) {
DCHECK_EQ(ipc_thread_id, CurrentWorkerId());

Powered by Google App Engine
This is Rietveld 408576698