[IndexedDB] Propogating changes to observers : Renderer

third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

Index: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
index db4a1ea7763e34fa39c8f7a7bf1e0167f75c5878..016d468477d0702d644aa894460de0cff1a8e7d6 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
@@ -8,8 +8,10 @@
 #include "bindings/modules/v8/ToV8ForModules.h"
 #include "bindings/modules/v8/V8BindingForModules.h"
 #include "core/dom/ExceptionCode.h"
+#include "modules/IndexedDBNames.h"
 #include "modules/indexeddb/IDBDatabase.h"
 #include "modules/indexeddb/IDBObserverCallback.h"
+#include "modules/indexeddb/IDBObserverChanges.h"
 #include "modules/indexeddb/IDBObserverInit.h"
 #include "modules/indexeddb/IDBTransaction.h"
 #include "modules/indexeddb/WebIDBObserverImpl.h"
@@ -27,6 +29,13 @@ IDBObserver::IDBObserver(IDBObserverCallback& callback, const IDBObserverInit& o
     , m_values(options.values())
     , m_noRecords(options.noRecords())
 {
+    // TODO(palakj): Throw an exception if unknown operation type.
+    DCHECK_EQ(m_operationTypes.size(), WebIDBOperationTypeCount);
+    m_operationTypes.reset();
+    m_operationTypes[WebIDBAdd] = options.operationTypes().contains(IndexedDBNames::add);
+    m_operationTypes[WebIDBPut] = options.operationTypes().contains(IndexedDBNames::put);
+    m_operationTypes[WebIDBDelete] = options.operationTypes().contains(IndexedDBNames::kDelete);
+    m_operationTypes[WebIDBClear] = options.operationTypes().contains(IndexedDBNames::clear);
 }
 
 IDBObserver::~IDBObserver() {}
@@ -49,7 +58,7 @@ void IDBObserver::observe(IDBDatabase* database, IDBTransaction* transaction, Ex
     std::unique_ptr<WebIDBObserverImpl> observer = WebIDBObserverImpl::create(this);
     WebIDBObserverImpl* observerPtr = observer.get();
     int32_t observerId = database->backend()->addObserver(std::move(observer), transaction->id());
-    m_observerIds.insert(observerId);
+    m_observerIds.add(observerId, database);
     observerPtr->setId(observerId);
 }
 
@@ -59,28 +68,37 @@ void IDBObserver::unobserve(IDBDatabase* database, ExceptionState& exceptionStat
         exceptionState.throwDOMException(InvalidStateError, IDBDatabase::databaseClosedErrorMessage);
         return;
     }
-    auto it = m_observerIds.begin();
-    std::vector<int32_t> observerIdsToRemove;
-    while (it != m_observerIds.end()) {
-        if (database->backend()->containsObserverId(*it)) {
-            observerIdsToRemove.push_back(*it);
-            it = m_observerIds.erase(it);
-        } else {
-            it++;
-        }
+
+    HeapHashMap<int32_t, WeakMember<IDBDatabase>> observersToRetain;
+    Vector<int32_t> observerIdsToRemove;
+    for (const auto& it : m_observerIds) {
+        if (it.value == database)
+            observerIdsToRemove.append(it.key);
+        else
+            observersToRetain.add(it.key, it.value);
     }
-    if (!observerIdsToRemove.empty())
+    m_observerIds.swap(observersToRetain);

[haraken, 2016/07/20 16:22:12]

Can we use m_observerIds.removeAll() instead of building up another hash map?

[palakj1, 2016/07/20 18:22:11]

I believed swapping would be faster, since, removeAll needs to iterate over all
the elements to be removed.
But it is definitely cleaner. I can switch to that.

+
+    if (!observerIdsToRemove.isEmpty())
         database->backend()->removeObservers(observerIdsToRemove);
 }
 
 void IDBObserver::removeObserver(int32_t id)
 {
-    m_observerIds.erase(id);
+    m_observerIds.remove(id);
+}
+
+void IDBObserver::onChange(int32_t id, const WebVector<WebIDBObservation>& observations, const WebVector<int32_t>& observationIndex)
+{
+    auto it = m_observerIds.find(id);
+    DCHECK(it != m_observerIds.end());
+    m_callback->handleChanges(*IDBObserverChanges::create(it->value, observations, observationIndex), *this);
 }
 
 DEFINE_TRACE(IDBObserver)
 {
     visitor->trace(m_callback);
+    visitor->trace(m_observerIds);
 }
 
 } // namespace blink