content/child/indexed_db/webidbdatabase_impl.h - Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/indexed_db/webidbdatabase_impl.h

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime

Patch Set: Renderer changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/indexed_db/indexed_db_dispatcher.cc ('K') | « content/child/indexed_db/indexed_db_key_builders.cc ('k') | content/child/indexed_db/webidbdatabase_impl.cc » ('j') | third_party/WebKit/LayoutTests/storage/indexeddb/resources/generic-idb-operations.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/indexed_db/webidbdatabase_impl.h

diff --git a/content/child/indexed_db/webidbdatabase_impl.h b/content/child/indexed_db/webidbdatabase_impl.h

index 2be351f1989d81b34555a0ec71ade20b12da53e9..85710030a8b3778bfbbafed2e865ee2a97b61ab6 100644

--- a/content/child/indexed_db/webidbdatabase_impl.h

+++ b/content/child/indexed_db/webidbdatabase_impl.h

@@ -7,6 +7,8 @@

#include <stdint.h>

+#include <set>

#include "base/memory/ref_counted.h"

#include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBCursor.h"

#include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h"

@@ -48,9 +50,8 @@ class WebIDBDatabaseImpl : public blink::WebIDBDatabase {

int32_t addObserver(std::unique_ptr<blink::WebIDBObserver>,

long long transactionId) override;

- bool containsObserverId(int32_t id) const override;

void removeObservers(

- const std::vector<int32_t>& observer_ids_to_remove) override;

+ const blink::WebVector<int32_t>& observer_ids_to_remove) override;

void get(long long transactionId,

long long objectStoreId,