content/browser/indexed_db/indexed_db_connection.cc - Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_connection.cc

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime

Patch Set: Post cmumford review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/indexed_db/indexed_db_callbacks.cc ('K') | « content/browser/indexed_db/indexed_db_connection.h ('k') | content/browser/indexed_db/indexed_db_database.h » ('j') | content/browser/indexed_db/indexed_db_database_callbacks.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_connection.cc

diff --git a/content/browser/indexed_db/indexed_db_connection.cc b/content/browser/indexed_db/indexed_db_connection.cc

index c2c7ebd266df6df2f445818775ad260965660cbb..08faceecd27ccade002c239da25246a7fb8ae8cb 100644

--- a/content/browser/indexed_db/indexed_db_connection.cc

+++ b/content/browser/indexed_db/indexed_db_connection.cc

@@ -12,10 +12,18 @@ namespace content {

IndexedDBConnection::IndexedDBConnection(

scoped_refptr<IndexedDBDatabase> database,

scoped_refptr<IndexedDBDatabaseCallbacks> callbacks)

- : database_(database), callbacks_(callbacks), weak_factory_(this) {}

+ : id_(kInvalidId),

+ database_(database),

+ callbacks_(callbacks),

+ weak_factory_(this) {}

IndexedDBConnection::~IndexedDBConnection() {}

+void IndexedDBConnection::setId(int32_t id) {

+ DCHECK_EQ(id_, kInvalidId);

+ id_ = id;

void IndexedDBConnection::Close() {

if (!callbacks_.get())

return;