Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: content/browser/indexed_db/indexed_db_connection.h

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime
Patch Set: Test added Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_connection.h
diff --git a/content/browser/indexed_db/indexed_db_connection.h b/content/browser/indexed_db/indexed_db_connection.h
index 3c305f39d057147c8a8feb12654a0f826404b09a..66ab65a4d8f8e2772d8382a5718280baf0865849 100644
--- a/content/browser/indexed_db/indexed_db_connection.h
+++ b/content/browser/indexed_db/indexed_db_connection.h
@@ -35,6 +35,9 @@ class CONTENT_EXPORT IndexedDBConnection {
// connection.
virtual void RemoveObservers(const std::vector<int32_t>& remove_observer_ids);
+ void set_id(int32_t id);
+ int32_t id() const { return id_; }
+
IndexedDBDatabase* database() const { return database_.get(); }
IndexedDBDatabaseCallbacks* callbacks() const { return callbacks_.get(); }
const std::vector<std::unique_ptr<IndexedDBObserver>>& active_observers()
@@ -46,9 +49,12 @@ class CONTENT_EXPORT IndexedDBConnection {
}
private:
+ enum { kInvalidId = -1 };
+ // id_ is ipc_database_id
+ int32_t id_ = kInvalidId;
palmer 2016/07/16 00:03:14 Style nit (ignore me if other people suggested to
palakj1 2016/07/18 22:02:29 It was suggested by jsbell that I do it here, sinc
+
// NULL in some unit tests, and after the connection is closed.
scoped_refptr<IndexedDBDatabase> database_;
-
// The callbacks_ member is cleared when the connection is closed.
// May be NULL in unit tests.
scoped_refptr<IndexedDBDatabaseCallbacks> callbacks_;
« no previous file with comments | « no previous file | content/browser/indexed_db/indexed_db_connection.cc » ('j') | content/browser/indexed_db/indexed_db_database.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698