[IndexedDB] Propogating changes to observers : Renderer

content/browser/indexed_db/indexed_db_transaction.cc

Index: content/browser/indexed_db/indexed_db_transaction.cc
diff --git a/content/browser/indexed_db/indexed_db_transaction.cc b/content/browser/indexed_db/indexed_db_transaction.cc
index 5de620da9bdbddf97f98f36f3b4703c6f583b6e2..944eda0f030f143c38a465b5dc5099a9b6c520c1 100644
--- a/content/browser/indexed_db/indexed_db_transaction.cc
+++ b/content/browser/indexed_db/indexed_db_transaction.cc
@@ -16,7 +16,9 @@
 #include "content/browser/indexed_db/indexed_db_cursor.h"
 #include "content/browser/indexed_db/indexed_db_database.h"
 #include "content/browser/indexed_db/indexed_db_database_callbacks.h"
+#include "content/browser/indexed_db/indexed_db_observation.h"
 #include "content/browser/indexed_db/indexed_db_observer.h"
+#include "content/browser/indexed_db/indexed_db_observer_changes.h"
 #include "content/browser/indexed_db/indexed_db_tracing.h"
 #include "content/browser/indexed_db/indexed_db_transaction_coordinator.h"
 #include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabaseException.h"
@@ -346,16 +348,25 @@ leveldb::Status IndexedDBTransaction::CommitPhaseTwo() {
   database_->transaction_coordinator().DidFinishTransaction(this);
 
   if (committed) {
-    // TODO (palakj) : Send Observations to observers
-    if (!pending_observers_.empty() && connection_)
-      connection_->ActivatePendingObservers(std::move(pending_observers_));
     abort_task_stack_.clear();
+
+    // SendObservations must happen before Oncomplete is fired to align with the

[jsbell, 2016/07/14 20:08:13]

nit: OnComplete

Also, maybe: "happen" -> "be called", and "fired" -> "called" (methods are
called, events are fired; I know we're not consistent in our existing comments,
though)

[palakj1, 2016/07/15 20:16:04]

My bad. Corrected.

+    // spec.
+    if (!connection_changes_map_.empty()) {
+      database_->SendObservations(std::move(connection_changes_map_));
+      connection_changes_map_.clear();
+    }
     {
       IDB_TRACE1(
           "IndexedDBTransaction::CommitPhaseTwo.TransactionCompleteCallbacks",
           "txn.id", id());
       callbacks_->OnComplete(id_);
     }
+    if (!pending_observers_.empty() && connection_) {
+      connection_->ActivatePendingObservers(std::move(pending_observers_));
+      pending_observers_.clear();
+    }
+
     database_->TransactionFinished(this, true);
   } else {
     while (!abort_task_stack_.empty())
@@ -455,9 +466,12 @@ void IndexedDBTransaction::CloseOpenCursors() {
   open_cursors_.clear();
 }
 
-void IndexedDBTransaction::AddPendingObserver(int32_t observer_id) {
-  pending_observers_.push_back(
-      base::WrapUnique(new IndexedDBObserver(observer_id)));
+void IndexedDBTransaction::AddPendingObserver(int32_t observer_id,

[cmumford, 2016/07/14 21:11:35]

Nothing wrong here, but you need to fix all calls to this function, specifically
content/browser/indexed_db/indexed_db_transaction_unittest.cc

[palakj1, 2016/07/15 20:16:04]

Done. thanks for pointing that out.

+                                              bool includeTransaction,
+                                              bool noRecords,
+                                              bool values) {
+  pending_observers_.push_back(base::WrapUnique(new IndexedDBObserver(
+      observer_id, object_store_ids_, includeTransaction, noRecords, values)));
 }
 
 void IndexedDBTransaction::RemovePendingObservers(
@@ -471,4 +485,26 @@ void IndexedDBTransaction::RemovePendingObservers(
     pending_observers_.erase(it, pending_observers_.end());
 }
 
+void IndexedDBTransaction::AddObservation(
+    int32_t connection_id,
+    std::unique_ptr<IndexedDBObservation> observation) {
+  auto it = connection_changes_map_.find(connection_id);
+  if (it == connection_changes_map_.end()) {
+    it = connection_changes_map_
+             .insert(std::make_pair(
+                 connection_id,
+                 base::WrapUnique(new IndexedDBObserverChanges())))
+             .first;
+  }
+  it->second->AddObservation(std::move(observation));
+}
+
+void IndexedDBTransaction::RecordObserverForLastObservation(
+    int32_t connection_id,
+    int32_t observer_id) {
+  auto it = connection_changes_map_.find(connection_id);
+  DCHECK(it != connection_changes_map_.end());
+  it->second->RecordObserverForLastObservation(observer_id);
+}
+
 }  // namespace content