third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.h - Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.h

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime

Patch Set: Implements Map in IDBObserverChanges idl Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/indexed_db/indexed_db_dispatcher.cc ('K') | « third_party/WebKit/Source/bindings/core/v8/ToV8.h ('k') | third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.cpp » ('j') | third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.h

diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.h b/third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.h

index cfb8cbf5ae2ff8a8d8d2365f01c7815145d73362..ca4f2eddf887782ee48a6bcb354a98495d6bd996 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.h

+++ b/third_party/WebKit/Source/bindings/modules/v8/V8IDBObserverCallback.h

@@ -21,6 +21,7 @@ public:

DECLARE_VIRTUAL_TRACE();

+ void handleEvent(IDBObserverChanges&, IDBObserver&) override;

dmurph 2016/07/13 23:29:13 nit: since we're technically not an event, can you

palakj1 2016/07/14 17:52:06 Thanks for pointing that out. Changed

ExecutionContext* getExecutionContext() const override { return ContextLifecycleObserver::getExecutionContext(); }

private:

ScopedPersistent<v8::Function> m_callback;