Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.h

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime
Patch Set: Propogating Changes to Renderer Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
index c85005677b75b4d05a78f5a7a8a103eb79d55a47..e87b74a35772ad86f95413f62b07ba76abfcc787 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
@@ -8,6 +8,7 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "modules/ModulesExport.h"
#include "platform/heap/Handle.h"
+#include "public/platform/modules/indexeddb/WebIDBTypes.h"
#include <set>
namespace blink {
@@ -17,6 +18,7 @@ class IDBDatabase;
class IDBObserverCallback;
class IDBObserverInit;
class IDBTransaction;
+struct WebIDBObservation;
class MODULES_EXPORT IDBObserver final : public GarbageCollectedFinalized<IDBObserver>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
@@ -29,6 +31,7 @@ public:
void observe(IDBDatabase*, IDBTransaction*, ExceptionState&);
void unobserve(IDBDatabase*, ExceptionState&);
void removeObserver(int32_t id);
+ void onChange(const std::vector<WebIDBObservation>&, const std::vector<int32_t>& observation_index);
DECLARE_TRACE();
@@ -39,6 +42,7 @@ private:
bool m_transaction;
bool m_values;
bool m_noRecords;
+ // bool m_operationType[WebIDBOperationTypeCount] = {true};
jsbell 2016/07/11 18:25:33 Remove or change into a TODO before landing
palakj1 2016/07/11 22:25:40 Done.
std::set<int32_t> m_observerIds;
};

Powered by Google App Engine
This is Rietveld 408576698