Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: content/browser/indexed_db/indexed_db_transaction.h

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime
Patch Set: Propogating Changes to Renderer Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_transaction.h
diff --git a/content/browser/indexed_db/indexed_db_transaction.h b/content/browser/indexed_db/indexed_db_transaction.h
index e889d4389ebb2780278c1a0d38b313dccf8b4ecf..6a579e2e6fdfbe5b6644c598d28743c0356d47e2 100644
--- a/content/browser/indexed_db/indexed_db_transaction.h
+++ b/content/browser/indexed_db/indexed_db_transaction.h
@@ -28,7 +28,9 @@ namespace content {
class BlobWriteCallbackImpl;
class IndexedDBCursor;
class IndexedDBDatabaseCallbacks;
+class IndexedDBObservation;
class IndexedDBObserver;
+class IndexedDBObserverChanges;
class CONTENT_EXPORT IndexedDBTransaction
: public NON_EXPORTED_BASE(base::RefCounted<IndexedDBTransaction>) {
@@ -69,6 +71,14 @@ class CONTENT_EXPORT IndexedDBTransaction
// Delete pending observers with ID's listed in |pending_observer_ids|.
void RemovePendingObservers(const std::vector<int32_t>& pending_observer_ids);
+ // Adds observation for the connection.
+ void AddObservation(int32_t connection_id,
+ std::unique_ptr<IndexedDBObservation>);
+ // Adds the last observation index to observer_id's list of recorded
+ // observation indices.
+ void RecordObserverForLastObservation(int32_t observer_id,
+ int32_t connection_id);
+
IndexedDBBackingStore::Transaction* BackingStoreTransaction() {
return transaction_.get();
}
@@ -144,6 +154,10 @@ class CONTENT_EXPORT IndexedDBTransaction
// Observers in pending queue do not listen to changes until activated.
std::vector<std::unique_ptr<IndexedDBObserver>> pending_observers_;
+ using ConnectionChangeMap =
jsbell 2016/07/11 18:25:33 Since this type is used in only one place, I would
palakj1 2016/07/11 22:25:40 Done.
+ std::map<int32_t, std::unique_ptr<IndexedDBObserverChanges>>;
+ ConnectionChangeMap connection_changes_map_;
+
class TaskQueue {
public:
TaskQueue();

Powered by Google App Engine
This is Rietveld 408576698