[IndexedDB] Propogating changes to observers : Renderer

third_party/WebKit/Source/modules/indexeddb/IDBObservation.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/indexeddb/IDBObservation.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ToV8.h"
 #include "bindings/modules/v8/ToV8ForModules.h"
 #include "bindings/modules/v8/V8BindingForModules.h"
 #include "modules/IndexedDBNames.h"
 #include "modules/indexeddb/IDBAny.h"
-#include "modules/indexeddb/IDBKey.h"
+#include "modules/indexeddb/IDBKeyRange.h"
 #include "modules/indexeddb/IDBValue.h"
+#include "public/platform/modules/indexeddb/WebIDBObservation.h"
 
 namespace blink {
 
 IDBObservation::~IDBObservation() {}
 
 ScriptValue IDBObservation::key(ScriptState* scriptState)
 {
-    return ScriptValue::from(scriptState, m_key);
+    if (!m_keyRange)
+        return ScriptValue::from(scriptState, v8::Undefined(scriptState->isolate()));

[haraken, 2016/07/20 16:22:12]

Haven't you made this change in https://codereview.chromium.org/2160163002/?

[palakj1, 2016/07/20 18:22:11]

No, I had later modified IDBObservation in 2160163002 to have only the renaming
changes. Since, we were using WebIDBObsevation which is a part of this cl.
Sorry, for the confusion.

+
+    return ScriptValue::from(scriptState, m_keyRange);
 }
 
 ScriptValue IDBObservation::value(ScriptState* scriptState)
 {
-    IDBAny* value;
-    if (!m_value) {
-        value = IDBAny::createUndefined();
-    } else {
-        value = IDBAny::create(m_value);
-    }
-    ScriptValue scriptValue = ScriptValue::from(scriptState, value);
-    return scriptValue;
+    if (!m_value)
+        return ScriptValue::from(scriptState, v8::Undefined(scriptState->isolate()));
+
+    return ScriptValue::from(scriptState, IDBAny::create(m_value));
 }
 
 WebIDBOperationType IDBObservation::stringToOperationType(const String& type)
 {
     if (type == IndexedDBNames::add)
         return WebIDBAdd;
     if (type == IndexedDBNames::put)
         return WebIDBPut;
     if (type == IndexedDBNames::kDelete)
         return WebIDBDelete;
@@ skipping 18 matching lines @@
 
     case WebIDBClear:
         return IndexedDBNames::clear;
 
     default:
         NOTREACHED();
         return IndexedDBNames::add;
     }
 }
 
-IDBObservation* IDBObservation::create(IDBKey* key, PassRefPtr<IDBValue> value, WebIDBOperationType type)
+IDBObservation* IDBObservation::create(const WebIDBObservation& observation)
 {
-    return new IDBObservation(key, value, type);
+    return new IDBObservation(observation);
 }
 
-IDBObservation::IDBObservation(IDBKey* key, PassRefPtr<IDBValue> value, WebIDBOperationType type)
-    : m_key(key)
-    , m_value(value)
-    , m_operationType(type)
+IDBObservation::IDBObservation(const WebIDBObservation& observation)
+    : m_keyRange(observation.keyRange)
+    , m_value(IDBValue::create(observation.value))
+    , m_operationType(observation.type)
 {
 }
 
 DEFINE_TRACE(IDBObservation)
 {
-    visitor->trace(m_key);
+    visitor->trace(m_keyRange);
 }
 
 } // namespace blink