Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/WebIDBObserverImpl.h

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime
Patch Set: Minor bugs fixed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebIDBObserverImpl_h 5 #ifndef WebIDBObserverImpl_h
6 #define WebIDBObserverImpl_h 6 #define WebIDBObserverImpl_h
7 7
8 #include "modules/indexeddb/IDBObserver.h"
8 #include "platform/heap/Persistent.h" 9 #include "platform/heap/Persistent.h"
9 #include "public/platform/modules/indexeddb/WebIDBObserver.h" 10 #include "public/platform/modules/indexeddb/WebIDBObserver.h"
11 #include <vector>
jsbell 2016/07/14 20:08:14 Not allowed...
palakj1 2016/07/15 20:16:05 Okay. Had used it in my previous cl as well. Chang
10 12
11 namespace blink { 13 namespace blink {
12 14
13 class IDBObserver; 15 class IDBObserver;
16 struct WebIDBObservation;
14 17
15 class WebIDBObserverImpl final : public WebIDBObserver { 18 class WebIDBObserverImpl final : public WebIDBObserver {
16 USING_FAST_MALLOC(WebIDBObserverImpl); 19 USING_FAST_MALLOC(WebIDBObserverImpl);
17 20
18 public: 21 public:
19 static std::unique_ptr<WebIDBObserverImpl> create(IDBObserver*); 22 static std::unique_ptr<WebIDBObserverImpl> create(IDBObserver*);
20 23
21 ~WebIDBObserverImpl() override; 24 ~WebIDBObserverImpl() override;
22 25
23 void setId(int32_t); 26 void setId(int32_t);
24 27
28 bool transaction() { return m_observer->transaction(); }
29 bool noRecords() { return m_observer->noRecords(); }
30 bool values() { return m_observer->values(); }
31 void onChange(const std::vector<WebIDBObservation>&, std::vector<int32_t> ob servationIndex);
jsbell 2016/07/14 20:08:14 Can't use std::vector here - use WebVector (which
palakj1 2016/07/15 20:16:05 Done.
32
25 private: 33 private:
26 enum { kInvalidObserverId = -1 }; 34 enum { kInvalidObserverId = -1 };
27 35
28 explicit WebIDBObserverImpl(IDBObserver*); 36 explicit WebIDBObserverImpl(IDBObserver*);
29 37
30 int32_t m_id; 38 int32_t m_id;
31 Persistent<IDBObserver> m_observer; 39 Persistent<IDBObserver> m_observer;
32 }; 40 };
33 41
34 } // namespace blink 42 } // namespace blink
35 43
36 #endif // WebIDBObserverImpl_h 44 #endif // WebIDBObserverImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698