Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp

Issue 2125213002: [IndexedDB] Propogating changes to observers : Renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lifetime
Patch Set: Minor bugs fixed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/indexeddb/IDBObserverChanges.h" 5 #include "modules/indexeddb/IDBObserverChanges.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/V8Binding.h"
9 #include "bindings/modules/v8/ToV8ForModules.h" 10 #include "bindings/modules/v8/ToV8ForModules.h"
10 #include "bindings/modules/v8/V8BindingForModules.h" 11 #include "bindings/modules/v8/V8BindingForModules.h"
11 #include "modules/indexeddb/IDBAny.h" 12 #include "modules/indexeddb/IDBAny.h"
13 #include "modules/indexeddb/IDBObservation.h"
14 #include "public/platform/modules/indexeddb/WebIDBObservation.h"
15 #include "public/platform/modules/indexeddb/WebIDBTypes.h"
12 16
13 namespace blink { 17 namespace blink {
14 18
15 ScriptValue IDBObserverChanges::records(ScriptState* scriptState) 19 ScriptValue IDBObserverChanges::records(ScriptState* scriptState)
16 { 20 {
17 return ScriptValue::from(scriptState, m_records); 21 v8::Local<v8::Context> context(scriptState->context());
22 v8::Isolate* isolate(scriptState->isolate());
23 v8::Local<v8::Map> map = v8::Map::New(isolate);
24 for (const auto& it : m_records) {
25 v8::Local<v8::String> key = v8String(isolate, m_database->getObjectStore Name(it.key));
26 v8::Local<v8::Value> value = toV8(it.value, context->Global(), isolate);
27 v8CallOrCrash(map->Set(context, key, value));
28 }
29 return ScriptValue::from(scriptState, map);
18 } 30 }
19 31
20 IDBObserverChanges* IDBObserverChanges::create(IDBDatabase* database, IDBTransac tion* transaction, IDBAny* records) 32 IDBObserverChanges* IDBObserverChanges::create(IDBDatabase* database, const std: :vector<WebIDBObservation>& observations, const std::vector<int32_t>& observatio nIndex)
21 { 33 {
22 return new IDBObserverChanges(database, transaction, records); 34 return new IDBObserverChanges(database, observations, observationIndex);
23 } 35 }
24 36
25 IDBObserverChanges::IDBObserverChanges(IDBDatabase* database, IDBTransaction* tr ansaction, IDBAny* records) 37 IDBObserverChanges::IDBObserverChanges(IDBDatabase* database, const std::vector< WebIDBObservation>& observations, const std::vector<int32_t>& observationIndex)
26 : m_database(database) 38 : m_database(database)
27 , m_transaction(transaction)
28 , m_records(records)
29 { 39 {
40 extractChanges(observations, observationIndex);
41 }
42
43 void IDBObserverChanges::extractChanges(const std::vector<WebIDBObservation>& ob servations, const std::vector<int32_t>& observationIndex)
44 {
45 for (const auto& idx : observationIndex)
46 m_records.add(observations[idx].objectStoreId, HeapVector<Member<IDBObse rvation>>()).storedValue->value.append(IDBObservation::create(observations[idx]) );
30 } 47 }
31 48
32 DEFINE_TRACE(IDBObserverChanges) 49 DEFINE_TRACE(IDBObserverChanges)
33 { 50 {
34 visitor->trace(m_database); 51 visitor->trace(m_database);
35 visitor->trace(m_transaction); 52 visitor->trace(m_transaction);
36 visitor->trace(m_records); 53 visitor->trace(m_records);
37 } 54 }
38 55
39 } // namespace blink 56 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698