experimental/PdfViewer/generate_code.py - Issue 21252003: pdfviewer: more prerequired work to have examples working for transparency work items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/generate_code.py

Issue 21252003: pdfviewer: more prerequired work to have examples working for transparency work items. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: experimental/PdfViewer/generate_code.py

===================================================================

--- experimental/PdfViewer/generate_code.py (revision 10427)

+++ experimental/PdfViewer/generate_code.py (working copy)

@@ -482,7 +482,7 @@

fileMapperNative.write(' SkPdfObjectType map' + name + '(const SkPdfObject* in) const;\n')

fileMapperNativeCpp.write('SkPdfObjectType SkPdfMapper::map' + name + '(const SkPdfObject* in) const {\n')

- fileMapperNativeCpp.write(' if (!is' + name + '(in)) return kNone_SkPdfObjectType;\n')

+ fileMapperNativeCpp.write(' if (in == NULL || !is' + name + '(in)) return kNone_SkPdfObjectType;\n')

fileMapperNativeCpp.write('\n')

if len(cls.fEnumSubclasses) > 0:

fileMapperNativeCpp.write(' SkPdfObjectType ret;\n')

« no previous file with comments | « experimental/PdfViewer/SkPdfRenderer.cpp ('k') | experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp » ('j') | no next file with comments »