Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Unified Diff: test/mjsunit/regress/regress-5173.js

Issue 2125163004: Correctly format builtin constructors in stack traces (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@20160704-string-number-builtins
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-function.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-5173.js
diff --git a/test/mjsunit/regress/regress-5173.js b/test/mjsunit/regress/regress-5173.js
index 250a687761160cbc06eba39a5e1be3842e4b8ffd..74f58cc4737c5366daae6dc6ebb89d4bb8ab11e3 100644
--- a/test/mjsunit/regress/regress-5173.js
+++ b/test/mjsunit/regress/regress-5173.js
@@ -33,12 +33,10 @@ testBuiltinInStackTrace("Date.prototype.getUTCDate.call('')",
"at String.getUTCDate");
testBuiltinInStackTrace("Date.prototype.getTime.call('')", "at String.getTime");
-// TODO(jgruber): These use a more generic expected string until detection of
-// assembly builtin constructors is fixed.
-testBuiltinInStackTrace("Number(thrower);", "Number");
-testBuiltinInStackTrace("new Number(thrower);", "Number");
-testBuiltinInStackTrace("String(thrower);", "String");
-testBuiltinInStackTrace("new String(thrower);", "String");
+testBuiltinInStackTrace("Number(thrower);", "at Number");
+testBuiltinInStackTrace("new Number(thrower);", "at new Number");
+testBuiltinInStackTrace("String(thrower);", "at String");
+testBuiltinInStackTrace("new String(thrower);", "at new String");
// Ensure we correctly pick up the receiver's string tag.
testBuiltinInStackTrace("Math.acos(thrower);", "at Math.acos");
« no previous file with comments | « src/runtime/runtime-function.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698