src/factory.cc - Issue 2125163004: Correctly format builtin constructors in stack traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 2125163004: Correctly format builtin constructors in stack traces (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@20160704-string-number-builtins

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 4140159f9312ffb8ce5c83fa4a536997c99fd8cf..347ed38db28db5fda8b1a5f48d3e33ec23b94454 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -2119,7 +2119,7 @@ Handle<SharedFunctionInfo> Factory::NewSharedFunctionInfo(

Handle<Code> construct_stub =

is_constructor ? isolate()->builtins()->JSConstructStubGeneric()

: isolate()->builtins()->ConstructedNonConstructable();

- share->set_construct_stub(*construct_stub);

+ share->SetConstructStub(*construct_stub);

share->set_instance_class_name(*Object_string());

share->set_function_data(*undefined_value(), SKIP_WRITE_BARRIER);

share->set_script(*undefined_value(), SKIP_WRITE_BARRIER);

« no previous file with comments | « src/compiler.cc ('k') | src/isolate.cc » ('j') | no next file with comments »