Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: src/objects-inl.h

Issue 2125163004: Correctly format builtin constructors in stack traces (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@20160704-string-number-builtins
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 4969 matching lines...) Expand 10 before | Expand all | Expand 10 after
4980 } 4980 }
4981 4981
4982 4982
4983 inline void Code::set_can_have_weak_objects(bool value) { 4983 inline void Code::set_can_have_weak_objects(bool value) {
4984 DCHECK(kind() == OPTIMIZED_FUNCTION); 4984 DCHECK(kind() == OPTIMIZED_FUNCTION);
4985 int previous = READ_UINT32_FIELD(this, kKindSpecificFlags1Offset); 4985 int previous = READ_UINT32_FIELD(this, kKindSpecificFlags1Offset);
4986 int updated = CanHaveWeakObjectsField::update(previous, value); 4986 int updated = CanHaveWeakObjectsField::update(previous, value);
4987 WRITE_UINT32_FIELD(this, kKindSpecificFlags1Offset, updated); 4987 WRITE_UINT32_FIELD(this, kKindSpecificFlags1Offset, updated);
4988 } 4988 }
4989 4989
4990 inline bool Code::is_construct_stub() {
4991 DCHECK(kind() == BUILTIN);
4992 return IsConstructStubField::decode(
4993 READ_UINT32_FIELD(this, kKindSpecificFlags1Offset));
4994 }
4995
4996 inline void Code::set_is_construct_stub(bool value) {
4997 DCHECK(kind() == BUILTIN);
4998 int previous = READ_UINT32_FIELD(this, kKindSpecificFlags1Offset);
4999 int updated = IsConstructStubField::update(previous, value);
5000 WRITE_UINT32_FIELD(this, kKindSpecificFlags1Offset, updated);
5001 }
4990 5002
4991 bool Code::has_deoptimization_support() { 5003 bool Code::has_deoptimization_support() {
4992 DCHECK_EQ(FUNCTION, kind()); 5004 DCHECK_EQ(FUNCTION, kind());
4993 unsigned flags = READ_UINT32_FIELD(this, kFullCodeFlags); 5005 unsigned flags = READ_UINT32_FIELD(this, kFullCodeFlags);
4994 return FullCodeFlagsHasDeoptimizationSupportField::decode(flags); 5006 return FullCodeFlagsHasDeoptimizationSupportField::decode(flags);
4995 } 5007 }
4996 5008
4997 5009
4998 void Code::set_has_deoptimization_support(bool value) { 5010 void Code::set_has_deoptimization_support(bool value) {
4999 DCHECK_EQ(FUNCTION, kind()); 5011 DCHECK_EQ(FUNCTION, kind());
(...skipping 3105 matching lines...) Expand 10 before | Expand all | Expand 10 after
8105 #undef WRITE_INT64_FIELD 8117 #undef WRITE_INT64_FIELD
8106 #undef READ_BYTE_FIELD 8118 #undef READ_BYTE_FIELD
8107 #undef WRITE_BYTE_FIELD 8119 #undef WRITE_BYTE_FIELD
8108 #undef NOBARRIER_READ_BYTE_FIELD 8120 #undef NOBARRIER_READ_BYTE_FIELD
8109 #undef NOBARRIER_WRITE_BYTE_FIELD 8121 #undef NOBARRIER_WRITE_BYTE_FIELD
8110 8122
8111 } // namespace internal 8123 } // namespace internal
8112 } // namespace v8 8124 } // namespace v8
8113 8125
8114 #endif // V8_OBJECTS_INL_H_ 8126 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698