Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: src/factory.cc

Issue 2125163004: Correctly format builtin constructors in stack traces (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@20160704-string-number-builtins
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/factory.h" 5 #include "src/factory.h"
6 6
7 #include "src/allocation-site-scopes.h" 7 #include "src/allocation-site-scopes.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/conversions.h" 10 #include "src/conversions.h"
(...skipping 2101 matching lines...) Expand 10 before | Expand all | Expand 10 after
2112 Handle<Code> code; 2112 Handle<Code> code;
2113 if (!maybe_code.ToHandle(&code)) { 2113 if (!maybe_code.ToHandle(&code)) {
2114 code = isolate()->builtins()->Illegal(); 2114 code = isolate()->builtins()->Illegal();
2115 } 2115 }
2116 share->set_code(*code); 2116 share->set_code(*code);
2117 share->set_optimized_code_map(*cleared_optimized_code_map()); 2117 share->set_optimized_code_map(*cleared_optimized_code_map());
2118 share->set_scope_info(ScopeInfo::Empty(isolate())); 2118 share->set_scope_info(ScopeInfo::Empty(isolate()));
2119 Handle<Code> construct_stub = 2119 Handle<Code> construct_stub =
2120 is_constructor ? isolate()->builtins()->JSConstructStubGeneric() 2120 is_constructor ? isolate()->builtins()->JSConstructStubGeneric()
2121 : isolate()->builtins()->ConstructedNonConstructable(); 2121 : isolate()->builtins()->ConstructedNonConstructable();
2122 share->set_construct_stub(*construct_stub); 2122 share->SetConstructStub(*construct_stub);
2123 share->set_instance_class_name(*Object_string()); 2123 share->set_instance_class_name(*Object_string());
2124 share->set_function_data(*undefined_value(), SKIP_WRITE_BARRIER); 2124 share->set_function_data(*undefined_value(), SKIP_WRITE_BARRIER);
2125 share->set_script(*undefined_value(), SKIP_WRITE_BARRIER); 2125 share->set_script(*undefined_value(), SKIP_WRITE_BARRIER);
2126 share->set_debug_info(DebugInfo::uninitialized(), SKIP_WRITE_BARRIER); 2126 share->set_debug_info(DebugInfo::uninitialized(), SKIP_WRITE_BARRIER);
2127 share->set_function_identifier(*undefined_value(), SKIP_WRITE_BARRIER); 2127 share->set_function_identifier(*undefined_value(), SKIP_WRITE_BARRIER);
2128 StaticFeedbackVectorSpec empty_spec; 2128 StaticFeedbackVectorSpec empty_spec;
2129 Handle<TypeFeedbackMetadata> feedback_metadata = 2129 Handle<TypeFeedbackMetadata> feedback_metadata =
2130 TypeFeedbackMetadata::New(isolate(), &empty_spec); 2130 TypeFeedbackMetadata::New(isolate(), &empty_spec);
2131 share->set_feedback_metadata(*feedback_metadata, SKIP_WRITE_BARRIER); 2131 share->set_feedback_metadata(*feedback_metadata, SKIP_WRITE_BARRIER);
2132 #if TRACE_MAPS 2132 #if TRACE_MAPS
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
2378 } 2378 }
2379 2379
2380 2380
2381 Handle<Object> Factory::ToBoolean(bool value) { 2381 Handle<Object> Factory::ToBoolean(bool value) {
2382 return value ? true_value() : false_value(); 2382 return value ? true_value() : false_value();
2383 } 2383 }
2384 2384
2385 2385
2386 } // namespace internal 2386 } // namespace internal
2387 } // namespace v8 2387 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698