Correctly format builtin constructors in stack traces

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/base/ieee754.h"
 #include "src/code-stubs.h"
@@ skipping 1288 matching lines @@
         array_function, isolate->factory()->InternalizeUtf8String("isArray"),
         Builtins::kArrayIsArray, 1, true);
     native_context()->set_is_arraylike(*is_arraylike);
   }
 
   {  // --- N u m b e r ---
     Handle<JSFunction> number_fun = InstallFunction(
         global, "Number", JS_VALUE_TYPE, JSValue::kSize,
         isolate->initial_object_prototype(), Builtins::kNumberConstructor);
     number_fun->shared()->DontAdaptArguments();
-    number_fun->shared()->set_construct_stub(
-        *isolate->builtins()->NumberConstructor_ConstructStub());
+    Handle<Code> code = isolate->builtins()->NumberConstructor_ConstructStub();
+    code->set_is_construct_stub(true);  // Mark as hand-written construct stub.
+    number_fun->shared()->set_construct_stub(*code);
     number_fun->shared()->set_length(1);
     InstallWithIntrinsicDefaultProto(isolate, number_fun,
                                      Context::NUMBER_FUNCTION_INDEX);
 
     // Create the %NumberPrototype%
     Handle<JSValue> prototype =
         Handle<JSValue>::cast(factory->NewJSObject(number_fun, TENURED));
     prototype->set_value(Smi::FromInt(0));
     Accessors::FunctionSetPrototype(number_fun, prototype).Assert();
 
@@ skipping 44 matching lines @@
     SimpleInstallFunction(prototype, "toString",
                           Builtins::kBooleanPrototypeToString, 0, true);
     SimpleInstallFunction(prototype, "valueOf",
                           Builtins::kBooleanPrototypeValueOf, 0, true);
   }
 
   {  // --- S t r i n g ---
     Handle<JSFunction> string_fun = InstallFunction(
         global, "String", JS_VALUE_TYPE, JSValue::kSize,
         isolate->initial_object_prototype(), Builtins::kStringConstructor);
-    string_fun->shared()->set_construct_stub(
-        *isolate->builtins()->StringConstructor_ConstructStub());
+    Handle<Code> code = isolate->builtins()->StringConstructor_ConstructStub();
+    code->set_is_construct_stub(true);
+    string_fun->shared()->set_construct_stub(*code);

[Yang, 2016/07/08 07:08:04]

Would it make sense to introduce a SharedFunctionInfo::SetConstructStub that
wraps both?

[jgruber, 2016/07/08 10:02:41]

set_construct_stub is also called on non-builtin shared function infos, so
probably not. We only need to set this bit for hand-written assembly construct
stubs.

[jgruber, 2016/07/08 10:11:59]

Disregard my previous comment, I did add SetConstructStub as suggested after
all.

     string_fun->shared()->DontAdaptArguments();
     string_fun->shared()->set_length(1);
     InstallWithIntrinsicDefaultProto(isolate, string_fun,
                                      Context::STRING_FUNCTION_INDEX);
 
     Handle<Map> string_map =
         Handle<Map>(native_context()->string_function()->initial_map());
     string_map->set_elements_kind(FAST_STRING_WRAPPER_ELEMENTS);
     Map::EnsureDescriptorSlack(string_map, 1);
 
@@ skipping 2629 matching lines @@
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 }  // namespace internal
 }  // namespace v8