Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2125153002: Check display list canvas fall back reason unknown (Closed)

Created:
4 years, 5 months ago by xidachen
Modified:
4 years, 5 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check display list canvas fall back reason unknown The FallbackReasonUnknown bin is still non-zero. This CL changes DCHECK to CHECK, such that when Unknown happens, browser crashes. This will hit canary first, once we have crash report with stack trace, we can fix it right away. BUG=585578 Committed: https://crrev.com/19ec8b20ec90c3e7d3a957ea3e5aeb2062e97962 Cr-Commit-Position: refs/heads/master@{#404040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
xidachen
PTAL
4 years, 5 months ago (2016-07-06 19:36:05 UTC) #2
Justin Novosad
On 2016/07/06 19:36:05, xidachen wrote: > PTAL lgtm
4 years, 5 months ago (2016-07-06 20:26:21 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125153002/1
4 years, 5 months ago (2016-07-06 20:27:52 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 23:51:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125153002/1
4 years, 5 months ago (2016-07-07 01:37:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 02:42:48 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 02:42:53 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 02:44:03 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19ec8b20ec90c3e7d3a957ea3e5aeb2062e97962
Cr-Commit-Position: refs/heads/master@{#404040}

Powered by Google App Engine
This is Rietveld 408576698