Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html

Issue 2125143002: [Devtools] Improved URL parser for console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wq Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html b/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html
index 4cce5682b00f96bb5da084612dae9dc1cf0c05e7..9a8f7086952f31b63c431cc5c5cd0f0a61ad2345 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html
@@ -8,7 +8,33 @@ console.log("follow http://www.chromium.org/");
console.log("string", "http://www.chromium.org/");
console.log(123, "http://www.chromium.org/");
console.log("http://www.chromium.org/some?v=114:56:57");
+console.log("http://[1234:0:0:0:8:800:200C:417A]/index.html");
+console.log("http://[1234:2a00:100:7031::1]");
+console.log("http://[1234::8:800:200C:417A]/foo");
+console.log("http://[::192.9.5.5]/ipng");
+console.log("http://[::FFFF:129.144.52.38]:80/index.html");
+console.log("http://[2010:836B:4179::836B:4179]");
+console.log("{x:'http://abc',bcd:'www.google.com'}");
+console.log("asdf\"www.google.com\"asdf");
+console.log("{http:'google.com'}");
+console.log("http://google.com:900a?");
+console.log("'www.google.com/ some spaces and stuff...'");
+console.log("http://w'ww.google.com");
+console.log("http://www.google...com");
+console.log("http://fo/test");
+console.log("http://fo/test#asdf&asdf?qwer!asdf:asdf::");
+console.log("http://fo/test?asdf#asdf&asdf?qwer!asdf:asdf::");
+console.log("http://fo/test/?asdf#asdf&asdf?qwer!asdf:asdf::");
+console.log("http://fo/test?/asdf#asdf&asdf?qwer!asdf:asdf::.");
+console.log("http://fo/test?/asdf#asdf&asdf?qwer!asdf:asdf::.oktext");
+console.log("http://fo/test?/asdf#asdf&asdf?qwer!asdf:asdf::. notpartofurl");
+
+console.log("=http://google.com");
+console.log("http://google.com");
+console.log("data:,not pass");
+console.log("'data:,this shall all pass'but not here");
+console.log("'data:,\"this shall all pass\";'");
function test()
{
@@ -19,9 +45,14 @@ function test()
var viewMessages = consoleView._visibleViewMessages;
for (var i = 0; i < viewMessages.length; ++i) {
var uiMessage = viewMessages[i];
- var element = uiMessage.contentElement();
- var href = element.querySelector(".webkit-html-external-link");
- InspectorTest.addResult("linked url:" + href.href);
+ var element = uiMessage.element();
+ var links = element.querySelectorAll(".webkit-html-external-link");
+ InspectorTest.addResult(element.innerText.trim());
+ if (!links.length)
+ InspectorTest.addResult(" No links");
+ for (var href of links) {
+ InspectorTest.addResult(" Url: " + href.href);
+ }
}
InspectorTest.completeTest();

Powered by Google App Engine
This is Rietveld 408576698