Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2125133004: Change src tag in requests to favicon service from Android NTP. (Closed)

Created:
4 years, 5 months ago by jkrcal
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change src tag in requests to favicon service from Android NTP. The previous src tag collides with the one used by desktop NTP (in the remote NTP). BUG=626235 Committed: https://crrev.com/1be153e760f4a2b60176864aa8fa94089765c42c Cr-Commit-Position: refs/heads/master@{#404613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
jkrcal
Bernhard, PTAL.
4 years, 5 months ago (2016-07-07 12:16:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125133004/1
4 years, 5 months ago (2016-07-07 12:19:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 13:01:19 UTC) #6
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-07 13:23:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125133004/1
4 years, 5 months ago (2016-07-11 07:35:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 08:12:01 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 08:12:04 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 08:13:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1be153e760f4a2b60176864aa8fa94089765c42c
Cr-Commit-Position: refs/heads/master@{#404613}

Powered by Google App Engine
This is Rietveld 408576698