Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2125133003: Rewrite thread_watcher_test. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/testing_support.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : with usage #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -59 lines) Patch
M testing_support/tests/thread_watcher_test.py View 1 1 chunk +87 lines, -59 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
tandrii(chromium)
4 years, 5 months ago (2016-07-07 09:29:23 UTC) #1
Sergiy Byelozyorov
I am not sure if using ThreadWatcherMixIn directly is good idea because this way we ...
4 years, 5 months ago (2016-07-07 10:20:39 UTC) #2
tandrii(chromium)
https://codereview.chromium.org/2125133003/diff/20001/testing_support/tests/thread_watcher_test.py File testing_support/tests/thread_watcher_test.py (right): https://codereview.chromium.org/2125133003/diff/20001/testing_support/tests/thread_watcher_test.py#newcode89 testing_support/tests/thread_watcher_test.py:89: class ThreadWatcherTestCaseUsageTest(thread_watcher.TestCase): testing actual usage turned out to be ...
4 years, 5 months ago (2016-07-07 11:33:57 UTC) #3
tandrii(chromium)
Committed patchset #2 (id:20001) manually as f2f2a3a000e40166572142c1ad88b48bbdbe2a68 (presubmit successful).
4 years, 5 months ago (2016-07-07 11:34:32 UTC) #5
Sergiy Byelozyorov
4 years, 5 months ago (2016-07-08 08:22:13 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2125133003/diff/20001/testing_support/tests/t...
File testing_support/tests/thread_watcher_test.py (right):

https://codereview.chromium.org/2125133003/diff/20001/testing_support/tests/t...
testing_support/tests/thread_watcher_test.py:89: class
ThreadWatcherTestCaseUsageTest(thread_watcher.TestCase):
On 2016/07/07 11:33:57, tandrii(chromium) wrote:
> testing actual usage turned out to be very simple

Awesome. Thanks.

Powered by Google App Engine
This is Rietveld 408576698