Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 212513002: :host-context should support functional notation only. (Closed)

Created:
6 years, 9 months ago by rune
Modified:
6 years, 9 months ago
Reviewers:
TabAtkins, dglazkov
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

:host-context should support functional notation only. Blink supported :host-context without a functional notation as an equivalent to :host. That is not allowed according to the CSS Scoping spec. BUG=356582 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170093

Patch Set 1 #

Patch Set 2 : Added test for invalid :host-context. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
M LayoutTests/fast/dom/shadow/hostcontext-pseudo-class.html View 1 13 chunks +28 lines, -14 lines 0 comments Download
M LayoutTests/fast/dom/shadow/hostcontext-pseudo-class-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
rune
6 years, 9 months ago (2014-03-26 09:24:38 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-03-26 16:31:43 UTC) #2
rune
The CQ bit was checked by rune@opera.com
6 years, 9 months ago (2014-03-26 17:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/212513002/30001
6 years, 9 months ago (2014-03-26 17:06:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 17:10:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-26 17:10:20 UTC) #6
rune
The CQ bit was checked by rune@opera.com
6 years, 9 months ago (2014-03-26 20:14:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/212513002/30001
6 years, 9 months ago (2014-03-26 20:14:23 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 20:24:37 UTC) #9
Message was sent while issue was closed.
Change committed as 170093

Powered by Google App Engine
This is Rietveld 408576698